Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: exercise drop of 2tb table #25837

Merged
merged 1 commit into from
May 28, 2018

Conversation

tbg
Copy link
Member

@tbg tbg commented May 23, 2018

This roachtest replicates the scenario described in #24029 and serves
as the basis for experimentation.

It currently fails:

[  13] clearrange: repeatedly running COUNT(*) on small table (5.0%|46s)
read 800 rows
[  14] clearrange: repeatedly running COUNT(*) on small table (10.0%|1m46s)
read 800 rows
[  15] clearrange: repeatedly running COUNT(*) on small table (15.0%|2m46s)
read 800 rows
[  16] clearrange: repeatedly running COUNT(*) on small table (20.0%|3m46s)
read 800 rows
[  17] clearrange: repeatedly running COUNT(*) on small table (25.0%|4m46s)
read 800 rows
[  18] clearrange: repeatedly running COUNT(*) on small table (30.0%|5m46s)
read 800 rows
[  19] clearrange: repeatedly running COUNT(*) on small table (35.0%|6m46s)
read 800 rows
[  20] clearrange: repeatedly running COUNT(*) on small table (40.0%|7m46s)
read 800 rows
[  21] clearrange: repeatedly running COUNT(*) on small table (45.0%|8m46s)
[  22] clearrange: repeatedly running COUNT(*) on small table (45.0%|9m46s)
[  23] clearrange: repeatedly running COUNT(*) on small table (45.0%|10m46s)
[  24] clearrange: repeatedly running COUNT(*) on small table (45.0%|11m46s)
read 800 rows
read 800 rows
[  25] clearrange: repeatedly running COUNT(*) on small table (55.0%|12m46s)
read 800 rows
[  26] clearrange: repeatedly running COUNT(*) on small table (60.0%|13m46s)
read 800 rows
[  27] clearrange: repeatedly running COUNT(*) on small table (65.0%|14m46s)
read 800 rows
[  28] clearrange: repeatedly running COUNT(*) on small table (70.0%|15m46s)
read 800 rows
[  29] clearrange: repeatedly running COUNT(*) on small table (75.0%|16m46s)
[  30] clearrange: repeatedly running COUNT(*) on small table (75.0%|17m46s)
[  31] clearrange: repeatedly running COUNT(*) on small table (75.0%|18m46s)
[  32] clearrange: repeatedly running COUNT(*) on small table (75.0%|19m46s)
[  33] clearrange: repeatedly running COUNT(*) on small table (75.0%|20m46s)
[  34] clearrange: repeatedly running COUNT(*) on small table (75.0%|21m46s)
[  35] clearrange: repeatedly running COUNT(*) on small table (75.0%|22m46s)
[  36] clearrange: repeatedly running COUNT(*) on small table (75.0%|23m46s)
[  37] clearrange: repeatedly running COUNT(*) on small table (75.0%|24m46s)
[  38] clearrange: repeatedly running COUNT(*) on small table (75.0%|25m46s)
[  39] clearrange: repeatedly running COUNT(*) on small table (75.0%|26m46s)
[  40] clearrange: repeatedly running COUNT(*) on small table (75.0%|27m46s)
[  41] clearrange: repeatedly running COUNT(*) on small table (75.0%|28m46s)
[  42] clearrange: repeatedly running COUNT(*) on small table (75.0%|29m46s)
[  43] clearrange: repeatedly running COUNT(*) on small table (75.0%|30m46s)
[  44] clearrange: repeatedly running COUNT(*) on small table (75.0%|31m46s)
[  45] clearrange: repeatedly running COUNT(*) on small table (75.0%|32m46s)
[  46] clearrange: repeatedly running COUNT(*) on small table (75.0%|33m46s)
[  47] clearrange: repeatedly running COUNT(*) on small table (75.0%|34m46s)
[  48] clearrange: repeatedly running COUNT(*) on small table (75.0%|35m46s)
...

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@petermattis
Copy link
Collaborator

:lgtm:


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.


pkg/cmd/roachtest/clearrange.go, line 33 at r1 (raw file):

		Stable: false,
		Run: func(ctx context.Context, t *test, c *cluster) {
			t.Status(`downloading store dumps`)

I could use a bit more commentary in this test. It took me a few reads to understand that the store dumps are large, while the import into tinybank is small.


Comments from Reviewable

@petermattis
Copy link
Collaborator

Do you plan to merge this? Perhaps mark it as skipped.


Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


Comments from Reviewable

This roachtest replicates the scenario described in cockroachdb#24029 and serves
as the basis for experimentation.

It currently fails.

Release note: None
@tbg tbg force-pushed the roachtest/clearrange branch from 36e5412 to 235d37d Compare May 28, 2018 05:03
@tbg
Copy link
Member Author

tbg commented May 28, 2018

TFTR! I'll merge this (and I'll leave it unskipped for a few days, just to see that it reliably fails and that I didn't introduce a bug in the home stretch).


Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


pkg/cmd/roachtest/clearrange.go, line 33 at r1 (raw file):

Previously, petermattis (Peter Mattis) wrote…

I could use a bit more commentary in this test. It took me a few reads to understand that the store dumps are large, while the import into tinybank is small.

Done.


Comments from Reviewable

@tbg
Copy link
Member Author

tbg commented May 28, 2018

bors r=petermattis

craig bot pushed a commit that referenced this pull request May 28, 2018
25837: roachtest: exercise drop of 2tb table r=petermattis a=tschottdorf

This roachtest replicates the scenario described in #24029 and serves
as the basis for experimentation.

It currently fails:

```
[  13] clearrange: repeatedly running COUNT(*) on small table (5.0%|46s)
read 800 rows
[  14] clearrange: repeatedly running COUNT(*) on small table (10.0%|1m46s)
read 800 rows
[  15] clearrange: repeatedly running COUNT(*) on small table (15.0%|2m46s)
read 800 rows
[  16] clearrange: repeatedly running COUNT(*) on small table (20.0%|3m46s)
read 800 rows
[  17] clearrange: repeatedly running COUNT(*) on small table (25.0%|4m46s)
read 800 rows
[  18] clearrange: repeatedly running COUNT(*) on small table (30.0%|5m46s)
read 800 rows
[  19] clearrange: repeatedly running COUNT(*) on small table (35.0%|6m46s)
read 800 rows
[  20] clearrange: repeatedly running COUNT(*) on small table (40.0%|7m46s)
read 800 rows
[  21] clearrange: repeatedly running COUNT(*) on small table (45.0%|8m46s)
[  22] clearrange: repeatedly running COUNT(*) on small table (45.0%|9m46s)
[  23] clearrange: repeatedly running COUNT(*) on small table (45.0%|10m46s)
[  24] clearrange: repeatedly running COUNT(*) on small table (45.0%|11m46s)
read 800 rows
read 800 rows
[  25] clearrange: repeatedly running COUNT(*) on small table (55.0%|12m46s)
read 800 rows
[  26] clearrange: repeatedly running COUNT(*) on small table (60.0%|13m46s)
read 800 rows
[  27] clearrange: repeatedly running COUNT(*) on small table (65.0%|14m46s)
read 800 rows
[  28] clearrange: repeatedly running COUNT(*) on small table (70.0%|15m46s)
read 800 rows
[  29] clearrange: repeatedly running COUNT(*) on small table (75.0%|16m46s)
[  30] clearrange: repeatedly running COUNT(*) on small table (75.0%|17m46s)
[  31] clearrange: repeatedly running COUNT(*) on small table (75.0%|18m46s)
[  32] clearrange: repeatedly running COUNT(*) on small table (75.0%|19m46s)
[  33] clearrange: repeatedly running COUNT(*) on small table (75.0%|20m46s)
[  34] clearrange: repeatedly running COUNT(*) on small table (75.0%|21m46s)
[  35] clearrange: repeatedly running COUNT(*) on small table (75.0%|22m46s)
[  36] clearrange: repeatedly running COUNT(*) on small table (75.0%|23m46s)
[  37] clearrange: repeatedly running COUNT(*) on small table (75.0%|24m46s)
[  38] clearrange: repeatedly running COUNT(*) on small table (75.0%|25m46s)
[  39] clearrange: repeatedly running COUNT(*) on small table (75.0%|26m46s)
[  40] clearrange: repeatedly running COUNT(*) on small table (75.0%|27m46s)
[  41] clearrange: repeatedly running COUNT(*) on small table (75.0%|28m46s)
[  42] clearrange: repeatedly running COUNT(*) on small table (75.0%|29m46s)
[  43] clearrange: repeatedly running COUNT(*) on small table (75.0%|30m46s)
[  44] clearrange: repeatedly running COUNT(*) on small table (75.0%|31m46s)
[  45] clearrange: repeatedly running COUNT(*) on small table (75.0%|32m46s)
[  46] clearrange: repeatedly running COUNT(*) on small table (75.0%|33m46s)
[  47] clearrange: repeatedly running COUNT(*) on small table (75.0%|34m46s)
[  48] clearrange: repeatedly running COUNT(*) on small table (75.0%|35m46s)
...
```

Release note: None

Co-authored-by: Tobias Schottdorf <[email protected]>
@craig
Copy link
Contributor

craig bot commented May 28, 2018

Build succeeded

@craig craig bot merged commit 235d37d into cockroachdb:master May 28, 2018
@tbg tbg deleted the roachtest/clearrange branch June 25, 2018 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants