Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: report internal distsql communication error as an internal error #14770

Closed
wants to merge 1 commit into from
Closed

sql: report internal distsql communication error as an internal error #14770

wants to merge 1 commit into from

Conversation

vivekmenezes
Copy link
Contributor

@vivekmenezes vivekmenezes commented Apr 10, 2017 •
edited
Loading

sql: report internal distsql communication error as an internal error
related to #31645

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@vivekmenezes vivekmenezes mentioned this pull request Apr 10, 2017
Merged
@vivekmenezes vivekmenezes requested review from a team October 23, 2018 17:06
@vivekmenezes vivekmenezes changed the title Do Not Merge: distsqlrun: test error propagates through distsql network sql: report internal distsql communication error as an internal error Oct 23, 2018
jordanlewis
jordanlewis reviewed Oct 23, 2018
View reviewed changes
pkg/sql/schema_changer.go Outdated
return false
}

return false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing this? Otherwise, a single deadline exceeded in a schema change will roll back the whole thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original code was returning false (not rolling back a schema change) only for an internal error with message deadline exceeded. The new code now doesn't rollback a schema change for any internal error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, okay. That seems dangerous too. Aren't there lots of internal errors that will never resolve themselves? That's why we have rollbacks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I hadn't seen the proliferation of internal error codes for bad sql type errors. I've reverted the change to catch this more precisely. Hate the need to look at messages!

@tbg tbg added the X-noremind Bots won't notify about PRs with X-noremind label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanlewis jordanlewis jordanlewis left review comments

Assignees
No one assigned
Labels
X-noremind Bots won't notify about PRs with X-noremind
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivekmenezes @cockroach-teamcity @jordanlewis @tbg