-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.3: stats, encoding: improve UUID-decoding error #136037
Conversation
Add a length check to `DecodeUUIDValue` and a more informative error wrapping to `DecodeUpperBound`, which will hopefully help us track down the cause of #128876. The wrapped error message looks like: ``` decoding histogram version 3 type uuid value ‹666f6f›: invalid uuid length of 2 ``` Informs: #128876 Epic: None Release note: None
0272300
to
660a14a
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball, @michae2, @mw5h, and @rytaft)
Backport 1/1 commits from #136015 on behalf of @michae2.
/cc @cockroachdb/release
Add a length check to
DecodeUUIDValue
and a more informative error wrapping toDecodeUpperBound
, which will hopefully help us track down the cause of #128876.The wrapped error message looks like:
Informs: #128876
Epic: None
Release note: None
Release justification: low-risk debugging for error.