From 12db3e30d60f3bb679a7fd53e0349484552412d9 Mon Sep 17 00:00:00 2001 From: Ibrahim Kettaneh Date: Wed, 20 Nov 2024 17:29:27 -0500 Subject: [PATCH] kvcoord: disable deadlock/race for expiration leases TestProxyTracing This commit disables deadlock/race runs for TestProxyTracing when running with expiration leases. The main reason is that it consumes resources unnecessarily. References: #135493 Release note: None --- pkg/kv/kvclient/kvcoord/dist_sender_server_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/kv/kvclient/kvcoord/dist_sender_server_test.go b/pkg/kv/kvclient/kvcoord/dist_sender_server_test.go index b8647b353f19..e7d75eadaed4 100644 --- a/pkg/kv/kvclient/kvcoord/dist_sender_server_test.go +++ b/pkg/kv/kvclient/kvcoord/dist_sender_server_test.go @@ -4818,7 +4818,10 @@ func TestProxyTracing(t *testing.T) { ctx := context.Background() testutils.RunValues(t, "lease-type", roachpb.LeaseTypes(), func(t *testing.T, leaseType roachpb.LeaseType) { - if leaseType == roachpb.LeaseEpoch { + if leaseType == roachpb.LeaseExpiration { + skip.UnderRace(t, "too slow") + skip.UnderDeadlock(t, "too slow") + } else if leaseType == roachpb.LeaseEpoch { // With epoch leases this test doesn't work reliably. It passes // in cases where it should fail and fails in cases where it // should pass.