roachtest: add kv/splits/nodes=3/quiesce=false/lease=leader #133216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvanbenschoten
added
the
backport-24.3.x
nvanbenschoten
requested review from
herkolategan and
vidit-bhat
and removed request for
a team
|
This change is |
|
We max out all 4 cpus on each node at about 100k ranges, so we'll need to do more work before we can push up to 300k ranges. One thing I see in profiles is a large, growing number of |
nvanbenschoten
force-pushed
the
nvanbenschoten/splitsTestLeaderLease
branch
2 times, most recently
from
3abf9d1
to
da7d126
Compare
nvanbenschoten
force-pushed
the
nvanbenschoten/splitsTestLeaderLease
branch
from
da7d126
to
fe1c554
Compare
This commit adds a `kv/splits/nodes=3/quiesce=false/lease=leader` test. It should be able to support 80k ranges even without quiescence, because leader leases use store liveness for failure detection and lease extension. To push higher than this, we will likely need to address cockroachdb#133885. Epic: None Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/splitsTestLeaderLease
branch
from
c5214cb
to
348352b
Compare
iskettaneh
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @herkolategan and @vidit-bhat)
iskettaneh
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status:
|
TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #132762.
This commit adds a
kv/splits/nodes=3/quiesce=false/lease=leadertest. It should be able to support 80k ranges even without quiescence, because leader leases use store liveness for failure detection and lease extension.To push higher than this, we will likely need to address #133885.
Release note: None