sql: use memo metadata to add routines and UDTs to statement bundles

[DrewKimball]

opt: replace "udf" with "routine" in the metadata

This commit changes the naming of some methods and data structures used
in query plan metadata to refer to "routines" instead of "udfs". This
clarifies that stored procedures are also valid targets for metadata
tracking.

Epic: None

Release note: None

sql: use memo metadata to add routines to statement bundles

This commit updates the statement bundle logic to take advantage of the
information stored in the query plan metadata so that only relevant routines
are shown in schema.sql for a statement bundle. In addition, stored
procedures are now tracked in the metadata in addition to UDFs. This has
no impact on query-plan caching, since we currently do not cache plans
that invoke stored procedures.

Fixes #132142
Fixes #104976

Release note (bug fix): Fixed a bug that prevented the create statement
for a routine from being shown in a statement bundle. This happened when
the routine was created on a schema other than public. The bug has
existed since v23.1.

sql: use memo metadata to add UDTs to statement bundle

This commit modifies the statement bundle collection logic to use the
query plan metadata to determine which types to display in schema.sql.
This ensures that only types which are referenced by the query are shown.

Informs #104976

Release note: None

[cockroach-teamcity]

This change is 

[yuzefovich]

Nice improvement!

Reviewed 4 of 4 files at r1, 3 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @mw5h)

---

pkg/sql/explain_bundle.go line 629 at r2 (raw file):

	}
	if mem.Metadata().HasUserDefinedRoutines() {
		// Get all relevant user-defined functions.

nit: s/functions/routines/.

---

pkg/sql/explain_bundle.go line 623 at r3 (raw file):

		}
	}
	// Get all user-defined types.

nit: maybe add "relevant" into the comment?

---

pkg/sql/opt/metadata.go line 1180 at r1 (raw file):

}

// TestingRoutineDepsEqual returns whether the UDF deps of the other Metadata are

nit: s/UDF deps/routine deps/.

---

pkg/sql/explain_bundle_test.go line 436 at r2 (raw file):

					reg = regexp.MustCompile("^foo")
					if reg.FindString(contents) != "" {
						return errors.Errorf("Found irrelevant function 'foo' in schema.sql")

nit: s/Found/found/.

[DrewKimball]

TFTR!

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @mw5h)

---

pkg/sql/explain_bundle.go line 629 at r2 (raw file):

Previously, yuzefovich (Yahor Yuzefovich) wrote…

nit: s/functions/routines/.

Done.

---

pkg/sql/explain_bundle.go line 623 at r3 (raw file):

Previously, yuzefovich (Yahor Yuzefovich) wrote…

nit: maybe add "relevant" into the comment?

Done.

---

pkg/sql/opt/metadata.go line 1180 at r1 (raw file):

Previously, yuzefovich (Yahor Yuzefovich) wrote…

nit: s/UDF deps/routine deps/.

Done.

---

pkg/sql/explain_bundle_test.go line 436 at r2 (raw file):

Previously, yuzefovich (Yahor Yuzefovich) wrote…

nit: s/Found/found/.

Done.

[DrewKimball]

bors r+

[craig]

Build failed (retrying...):

• linux_arm64_build

[craig]

Build succeeded:

• docker_image_amd64
• unit_tests
• macos_amd64_build
• acceptance
• local_roachtest
• lint
• windows_build
• examples_orms
• check_generated_code
• macos_arm64_build
• linux_amd64_fips_build
• local_roachtest_fips
• linux_arm64_build
• linux_amd64_build

[blathers-crl]

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.

---

Issue #104976: branch-release-23.2, branch-release-24.1, branch-release-24.2.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from 09c2e3d to blathers/backport-release-23.2-132147: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.

---

error creating merge commit from 09c2e3d to blathers/backport-release-24.1-132147: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.1.x failed. See errors above.

---

error creating merge commit from 09c2e3d to blathers/backport-release-24.2-132147: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.2.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}