server: add StoreIDs to SpanStats response
#130049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
This commit adds a new response field to the SpanStats rpc, `StoreIDs` which is a list of unique store ids in ascending order that store the requestd span. Fixes: cockroachdb#129060 Release note: None
xinhaoz
force-pushed
the
span-stats-store-ids
branch
from
f09d80e to
fbd2ae6
Compare
xinhaoz
requested review from
angles-n-daemons
and removed request for
a team
| // Verify stats across different spans. | ||
| for _, tcase := range testCases { | ||
| rSpan, err := keys.SpanAddr(tcase.span) | ||
| require.NoError(t, err) | ||
|
|
||
| // Assert expected values from multi-span request | ||
| spanStats := multiResult.SpanToStats[tcase.span.String()] | ||
| if !equalStoreIDs([]roachpb.StoreID{1, 2, 3}, spanStats.StoreIDs) { |
There was a problem hiding this comment.
nice, great test
angles-n-daemons
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new response field to the
SpanStats rpc,
StoreIDswhich is a list ofunique store ids in ascending order that store
the requested span.
Fixes: #129060
Release note: None