-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvserver: deflake TestRangefeedCheckpointsRecoverFromLeaseExpiration #129279
Conversation
5a8c82d
to
f06b73f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job getting to the bottom of this!
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @iskettaneh)
pkg/kv/kvserver/replica_rangefeed_test.go
line 1673 at r1 (raw file):
// Ask another node to increment n2's liveness record, but first, wait until // both nodes view on the liveness expiration converge.
nit: This deserves more explanation. Consider rewording to something like:
"but first, wait until n1's liveness state is the same as n2's. Otherwise, the epoch below might get rejected because of mismatching liveness records".
This commit does two things to deflake the test: 1) Takes the MinExpiration into consideration when advancing the clock to cause the epoch lease to expire. This is important after the feature was enabled in: ba758c0 2) Waits for N1's view of N2's lease expiration to match N2's view. This is important in the rare case where N1 tries to increase N2's epoch, but it has a stale view of the lease expiration time. Fixes: cockroachdb#124178, cockroachdb#123551 Epic: None Release note: None
f06b73f
to
f985c4f
Compare
bors r+ |
This commit does two things to deflake the test:
Fixes: #124178, #123551
Epic: None
Release note: None