workload/schemachange: avoid commmenting on transient check constraints #128833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafiss
requested review from
DarrylWong and
renatolabs
and removed request for
a team
|
This change is |
annrpom
approved these changes
Aug 12, 2024
These check constraints are added temporarily while adding a non-nullable column. We have seen flakes caused by the workload trying to refer to them. Release note: None
rafiss
force-pushed
the
fix-rsw-transient-constraint
branch
from
5fe7cb6 to
aff5d21
Compare
|
tftr! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These check constraints are added temporarily while adding a non-nullable column. We have seen flakes caused by the workload trying to refer to them.
informs #128615
Release note: None