Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: scaffolding for db metadata update job #128470

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

xinhaoz
Copy link
Member

@xinhaoz xinhaoz commented Aug 7, 2024

This commit creates a new forever running BG job called UpdateCachedTableMetadata. This is just some scaffolding - the job doesn't do anything right now but it will be used to populate the system table storing cached table metadata used by obs surfaces.

Epic: CRDB-37558
Fixes: #127891

Release note: None

Copy link

blathers-crl bot commented Aug 7, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@xinhaoz xinhaoz force-pushed the add-table-metadata-update-job branch from ac0b7d4 to e215411 Compare August 7, 2024 22:16
@xinhaoz xinhaoz force-pushed the add-table-metadata-update-job branch from e215411 to 33f1601 Compare August 16, 2024 21:10
@xinhaoz xinhaoz changed the title sql/dbdetailscache: scaffolding for db metadata update job sql: scaffolding for db metadata update job Aug 16, 2024
@xinhaoz xinhaoz force-pushed the add-table-metadata-update-job branch 3 times, most recently from 632e175 to f741c74 Compare August 22, 2024 15:21
@xinhaoz xinhaoz marked this pull request as ready for review August 22, 2024 15:22
@xinhaoz xinhaoz requested review from a team as code owners August 22, 2024 15:22
@xinhaoz xinhaoz requested review from stevendanna, kyle-a-wong and a team and removed request for a team August 22, 2024 15:22
@xinhaoz xinhaoz force-pushed the add-table-metadata-update-job branch from f741c74 to 163400d Compare August 23, 2024 17:38
Copy link
Contributor

@kyle-a-wong kyle-a-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a comment about the epic in the commit message, but otherwise, :lgtm:

Reviewed 8 of 17 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @stevendanna and @xinhaoz)


-- commits line 10 at r1:
nit: This should be CRDB-37558 right?

Code quote:

Epic: none

@xinhaoz xinhaoz force-pushed the add-table-metadata-update-job branch from 163400d to ec7e23b Compare August 26, 2024 15:09
@xinhaoz xinhaoz requested a review from kyle-a-wong August 26, 2024 15:42
@xinhaoz
Copy link
Member Author

xinhaoz commented Aug 26, 2024

@kyle-a-wong Just renamed some stuff (updateCachedTableMetadata -> updateTableMetadataCache), can you re-approve if that looks good? Also added git issue and epic link!

@xinhaoz xinhaoz force-pushed the add-table-metadata-update-job branch from ec7e23b to c2a8b13 Compare August 26, 2024 17:08
Copy link
Contributor

@kyle-a-wong kyle-a-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 17 files at r1, 6 of 6 files at r3, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @stevendanna and @xinhaoz)


pkg/upgrade/upgradebase/testing_knobs.go line 77 at r3 (raw file):

	SkipMVCCStatisticsJobBootstrap bool

	SkipUpdateCachedTableMetadataBootstrap bool

nit: Should this be updated too, or was it left out intentionally?

Code quote:

SkipUpdateCachedTableMetadataBootstrap 

@xinhaoz xinhaoz force-pushed the add-table-metadata-update-job branch from c2a8b13 to b30d0de Compare August 26, 2024 18:29
This commit creates a new forever running BG job called
UpdateCachedTableMetadata. This is just some scaffolding -
the job doesn't do anything right now but it will be used
to populate the system table storing cached table metadata
used by obs surfaces.

Epic: CRDB-37558
Fixes: cockroachdb#127891

Release note: None
@xinhaoz xinhaoz force-pushed the add-table-metadata-update-job branch from b30d0de to b010907 Compare August 26, 2024 19:05
@xinhaoz
Copy link
Member Author

xinhaoz commented Aug 27, 2024

TFTR!
bors r+

@craig craig bot merged commit 5d8155f into cockroachdb:master Aug 27, 2024
23 checks passed
@xinhaoz xinhaoz deleted the add-table-metadata-update-job branch September 20, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: add scaffolding for job to compute table metadata and insert into system table
3 participants