-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: scaffolding for db metadata update job #128470
sql: scaffolding for db metadata update job #128470
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
ac0b7d4
to
e215411
Compare
e215411
to
33f1601
Compare
632e175
to
f741c74
Compare
f741c74
to
163400d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a comment about the epic in the commit message, but otherwise,
Reviewed 8 of 17 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @stevendanna and @xinhaoz)
-- commits
line 10 at r1:
nit: This should be CRDB-37558 right?
Code quote:
Epic: none
163400d
to
ec7e23b
Compare
@kyle-a-wong Just renamed some stuff (updateCachedTableMetadata -> updateTableMetadataCache), can you re-approve if that looks good? Also added git issue and epic link! |
ec7e23b
to
c2a8b13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 17 files at r1, 6 of 6 files at r3, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @stevendanna and @xinhaoz)
pkg/upgrade/upgradebase/testing_knobs.go
line 77 at r3 (raw file):
SkipMVCCStatisticsJobBootstrap bool SkipUpdateCachedTableMetadataBootstrap bool
nit: Should this be updated too, or was it left out intentionally?
Code quote:
SkipUpdateCachedTableMetadataBootstrap
c2a8b13
to
b30d0de
Compare
This commit creates a new forever running BG job called UpdateCachedTableMetadata. This is just some scaffolding - the job doesn't do anything right now but it will be used to populate the system table storing cached table metadata used by obs surfaces. Epic: CRDB-37558 Fixes: cockroachdb#127891 Release note: None
b30d0de
to
b010907
Compare
TFTR! |
This commit creates a new forever running BG job called UpdateCachedTableMetadata. This is just some scaffolding - the job doesn't do anything right now but it will be used to populate the system table storing cached table metadata used by obs surfaces.
Epic: CRDB-37558
Fixes: #127891
Release note: None