-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow: add cockroach-microbench-ci step in github actions #127228
Conversation
b2085aa
to
57284c8
Compare
9ec7527
to
cafc986
Compare
d0e2c23
to
6e77eab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. A few comments: I realised you might have copied some of my earlier work regarding using dev
to build roachprod-microbench
. I've been meaning to update it to use the CI way run_bazel
rather. It should be an easy update here.
ca2246c
to
bd75265
Compare
e3be5ed
to
cb0bdd1
Compare
cb0bdd1
to
c2f5ad4
Compare
c2f5ad4
to
eeadeb8
Compare
704bc65
to
56b223e
Compare
By the way, the build is failing, please have a look at that. |
Fixes: cockroachdb#106661 Release note: None Epic: https://cockroachlabs.atlassian.net/browse/CRDB-29662 This change intends to add a new CI step which will run `BenchmarkKV` microbenchmark for the current commit and compares the result with that of the base commit's results which is stored in a cloud bucket. This is needed to avoid minor perf regressions so that any regression is caught in the PR itself. The current threshold is set to 5%. There are highly 3 steps 1. Run benchmarks 2. If this is PR branch, download the latest commit of the target branch's bench results from the cloud storage and compare the results. If there's a regression fail here itself 3. If it is a push step (PR merge to master/release), upload the result to the cloud storage with the current commit sha. Currently, this change won't block the PR. However it will still run the microbenchmarks and upload the results during the push step.
56b223e
to
8cde169
Compare
@rickystewart Fixed it. PTAL |
Are you aware that the script in CI does not seem to be working correctly?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke with Herko and it seems the current behavior is expected so this is fine.
Yes, this is expected since there's no bench file for the current latest master commit. Thanks for the review ! |
TFTR! bors r=rickystewart,herkolategan |
Fixes: #106661
Release note: None
Epic: https://cockroachlabs.atlassian.net/browse/CRDB-29662
This change intends to add a new CI step which will run
BenchmarkKV
microbenchmark for the current commit and compares the result with that of the base commit's results which is stored in a cloud bucket.This is needed to avoid minor perf regressions so that any regression is caught in the PR itself. The current threshold is set to 5%.
There are highly 3 steps
Currently, this change won't block the PR. However it will still run the microbenchmarks and upload the results during the push step.