Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv/kvclient/kvtenant: allow downloading ones own spans #121257

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

dt
Copy link
Member

@dt dt commented Mar 28, 2024

Release note: none.
Epic: none.

@dt dt requested a review from stevendanna March 28, 2024 03:30
@dt dt requested a review from a team as a code owner March 28, 2024 03:30
Copy link

blathers-crl bot commented Mar 28, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Once we've let you link an sst, we should trust you to download it.

@msbutler
Copy link
Collaborator

to test this, you could relax the requirements in online_restore_test.go to use system tenants

@dt
Copy link
Member Author

dt commented Apr 1, 2024

bors r=stevendanna

@craig craig bot merged commit c43f54c into cockroachdb:master Apr 1, 2024
21 of 22 checks passed
@dt dt deleted the trestore branch April 3, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backupccl: online restore download job fails when run from a shared process main tenant tenant
4 participants