optbuilder: fix recently introduced nil pointer in error case #121222
Conversation
This commit fixes a recently introduced nil pointer internal error when attempting to CALL not a procedure that is specified not by its name. `ResolvableFunctionReference` might not have `ReferenceByName`, so this commit switches to using `FunctionReference` that is always set. Release note: None
|
This change is |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball, @mgartner, and @yuzefovich)
pkg/sql/opt/optbuilder/routine.go line 129 at r1 (raw file):
if !ok { panic(pgerror.Newf(pgcode.WrongObjectType, "%s is not a procedure", c.Proc.Func.String(),
micro-nit: I think if you use %v on c.Proc.Func, then String() will be called automatically. But this is fine, too, of course.
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/sql/opt/optbuilder/routine.go line 129 at r1 (raw file):
Previously, michae2 (Michael Erickson) wrote…
micro-nit: I think if you use %v on c.Proc.Func, then String() will be called automatically. But this is fine, too, of course.
Yeah, I think you're right, but I prefer being explicit, so I'll keep this as is.
This commit fixes a recently introduced nil pointer internal error when attempting to CALL not a procedure that is specified not by its name.
ResolvableFunctionReferencemight not haveReferenceByName, so this commit switches to usingFunctionReferencethat is always set.Fixes: #121095.
Release note: None