sqlstats: fix reset in-memory sql stats on flush #121156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinhaoz
requested review from
a team and
dhartunian
and removed request for
a team
|
This change is |
dhartunian
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
pkg/sql/sqlstats/ssmemstorage/ss_mem_storage.go line 663 at r1 (raw file):
} func (s *Container) clearLocked(ctx context.Context) {
can you add a docstring here to explain that freeLocked needs to happen first and why.
After flushing in-memory sql stats to disk, we reset and prep each app container for reuse by: - Decrementing the per-node fingerprint counter by the size of the app container. This counter prevents us from writing more sql stats when we reach the maximum amount of fingerprints stored in memory. - Clearing the container and reducing its capacity to 1/2. When introducing atomic flushing, we swapped the 2 ops above in the reset step, resulting in the decrement step being a noop. The counter never resets and eventually results in each attempt at writing sql stats to be throttled which then also signals the sql stats flush worker. Epic: none Fixes: cockroachdb#121134 Release note: None
xinhaoz
force-pushed
the
fix-reset-flush
branch
from
fe2415a to
ee97259
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After flushing in-memory sql stats to disk, we reset and prep each app container for reuse by:
When introducing atomic flushing, we swapped the 2 ops above in the reset step, resulting in the decrement step being a noop. The counter never resets and eventually results in each attempt at writing sql stats to be throttled which then also signals the sql stats flush worker.
Epic: none
Fixes: #121134
Release note: None