From b11af97e26fbde15fcbd6eb59ccdc53037543013 Mon Sep 17 00:00:00 2001 From: Austen McClernon Date: Mon, 31 Jul 2023 17:58:08 +0000 Subject: [PATCH] roachtest: output error and bump vmodule on lease preferences test The `lease-preferences` roachtest did not log the state of preference conformance on timeout. This commit updates the error check, hit on timeout, to show the result. Also bump the vmodule settings to show lease acquisitions and lease preference errors. Epic: none Informs: #107862 Release note: None --- pkg/cmd/roachtest/tests/lease_preferences.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/cmd/roachtest/tests/lease_preferences.go b/pkg/cmd/roachtest/tests/lease_preferences.go index 23172963321b..460d1bd801df 100644 --- a/pkg/cmd/roachtest/tests/lease_preferences.go +++ b/pkg/cmd/roachtest/tests/lease_preferences.go @@ -188,7 +188,8 @@ func runLeasePreferences( // dc=2: n3 n4 // ... // dc=N: n2N-1 n2N - fmt.Sprintf("--locality=region=fake-region,zone=fake-zone,dc=%d", (node-1)/2+1)) + fmt.Sprintf("--locality=region=fake-region,zone=fake-zone,dc=%d", (node-1)/2+1), + "--vmodule=replica_proposal=2,replicate_queue=3,replicate=3") c.Start(ctx, t.L(), opts, settings, c.Node(node)) } @@ -223,7 +224,7 @@ func runLeasePreferences( checkLeasePreferenceConformance := func(ctx context.Context) { result, err := waitForLeasePreferences( ctx, t, c, spec.checkNodes, spec.waitForLessPreferred, stableDuration) - require.NoError(t, err) + require.NoError(t, err, result) require.Truef(t, !result.violating(), "violating lease preferences %s", result) if spec.waitForLessPreferred { require.Truef(t, !result.lessPreferred(), "less preferred preferences %s", result)