Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: remove './cockroach sql' incantations from restore roachtests #106216

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

msbutler
Copy link
Collaborator

@msbutler msbutler commented Jul 5, 2023

The patch removes all './cockroach sql' incantations from the restore roachtest driver, which previously would cause the backupFixture test to fail if the user passed a binary not named 'cockroach'.

Fixes #105952

Release note: None

The patch removes all './cockroach sql' incantations from the restore roachtest
driver, which previously would cause the backupFixture test to fail if the user
passed a binary not named 'cockroach'.

Fixes cockroachdb#105952

Release note: None
@msbutler msbutler requested review from dt and renatolabs July 5, 2023 20:49
@msbutler msbutler self-assigned this Jul 5, 2023
@msbutler msbutler requested a review from a team as a code owner July 5, 2023 20:49
@msbutler msbutler requested review from herkolategan and removed request for a team July 5, 2023 20:49
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler
Copy link
Collaborator Author

msbutler commented Jul 6, 2023

TFTR!

bors r=dt

@craig
Copy link
Contributor

craig bot commented Jul 6, 2023

Build succeeded:

@craig craig bot merged commit e38486c into cockroachdb:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: backupFixture/tpce/15GB/aws failed
3 participants