Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/schemachanger: add telemetry to know which statements are run under declarative vs legacy schema changer #99386

Closed
fqazi opened this issue Mar 23, 2023 · 4 comments · Fixed by #105108
Assignees
Labels
C-wishlist A wishlist feature. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@fqazi
Copy link
Collaborator

fqazi commented Mar 23, 2023

Currently, we have no telemetry that tells us how many schema changes are used in the declarative schema changer and which ones are forced to fall back. Having some type of telemetry would allow us to understand usage patterns and limitations hit by real-world customers. Also, give us a good indication of the coverage we are offering today

Jira issue: CRDB-25859

Epic CRDB-27601

@fqazi fqazi added C-wishlist A wishlist feature. T-sql-schema-deprecated Use T-sql-foundations instead labels Mar 23, 2023
@fqazi
Copy link
Collaborator Author

fqazi commented Mar 23, 2023

@dikshant This is probably something handy for us to understand the usage of the declarative schema changer

@dikshant
Copy link

dikshant commented Mar 23, 2023

Ah yes we should definitely work on this for 23.2 and even backport if we can to 22.2.

@rafiss
Copy link
Collaborator

rafiss commented Mar 23, 2023

Do we already have a sense of how much effort is required? If it's low, I'd vote for starting this work right now during the stability period.

@ajwerner
Copy link
Contributor

We would want to add a field here:

sampledQuery := eventpb.SampledQuery{

If the plan in curPlan has a schemaChangePlanNode then it ran with the declarative schema changer. That should be easy to detect.

@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
@rafiss rafiss assigned rafiss and unassigned fqazi Jun 15, 2023
@craig craig bot closed this as completed in a2c2c06 Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-wishlist A wishlist feature. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants