Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: TestTrace failed #98971

Closed
cockroach-teamcity opened this issue Mar 19, 2023 · 5 comments · Fixed by #99062
Closed

sql: TestTrace failed #98971

cockroach-teamcity opened this issue Mar 19, 2023 · 5 comments · Fixed by #99062
Assignees
@erikgrinaker
Labels
branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). GA-blocker O-robot Originated from a bot. T-kv KV Team
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 19, 2023 •
edited by cockroach-jira-scripts
Loading

sql.TestTrace failed with artifacts on master @ 53dbb86acb1d48309530181b94838faf937084d3:

=== RUN   TestTrace
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/b287de7194e17a0386ee1775f0d198ba/logTestTrace3285791219
    test_log_scope.go:79: use -show-logs to present logs inline
=== CONT  TestTrace
    trace_test.go:412: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/b287de7194e17a0386ee1775f0d198ba/logTestTrace3285791219
--- FAIL: TestTrace (5.18s)
=== RUN   TestTrace/ShowTraceFor
    --- FAIL: TestTrace/ShowTraceFor (0.12s)
=== RUN   TestTrace/ShowTraceFor/TracingOn
        --- FAIL: TestTrace/ShowTraceFor/TracingOn (0.07s)
=== RUN   TestTrace/ShowTraceFor/TracingOn/node-1
    trace_test.go:386: expected span: "session recording", got: "pendingLeaseRequest: requesting lease"
    trace_test.go:397: remaining span: "session recording"
    trace_test.go:397: remaining span: "sql query"
    trace_test.go:397: remaining span: "sql txn"
    trace_test.go:397: remaining span: "table reader"
    trace_test.go:397: remaining span: "txn coordinator send"
            --- FAIL: TestTrace/ShowTraceFor/TracingOn/node-1 (0.02s)

Parameters: TAGS=bazel,gss

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-25634
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Mar 19, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Mar 19, 2023
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Mar 19, 2023
@cockroach-teamcity
Copy link
Member Author

sql.TestTrace failed with artifacts on master @ 1cf75095871a9df935c036c674783dca73a02134:

=== RUN   TestTrace
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/68358425a2d75ead146501979d1133be/logTestTrace1879366551
    test_log_scope.go:79: use -show-logs to present logs inline
=== CONT  TestTrace
    trace_test.go:412: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/68358425a2d75ead146501979d1133be/logTestTrace1879366551
--- FAIL: TestTrace (6.57s)
=== RUN   TestTrace/ShowTraceForDistSQL
    --- FAIL: TestTrace/ShowTraceForDistSQL (0.18s)
=== RUN   TestTrace/ShowTraceForDistSQL/TracingOn
        --- FAIL: TestTrace/ShowTraceForDistSQL/TracingOn (0.10s)
=== RUN   TestTrace/ShowTraceForDistSQL/TracingOn/node-1
    trace_test.go:386: expected span: "session recording", got: "pendingLeaseRequest: requesting lease"
    trace_test.go:397: remaining span: "session recording"
    trace_test.go:397: remaining span: "sql query"
    trace_test.go:397: remaining span: "sql txn"
    trace_test.go:397: remaining span: "table reader"
    trace_test.go:397: remaining span: "txn coordinator send"
            --- FAIL: TestTrace/ShowTraceForDistSQL/TracingOn/node-1 (0.04s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@knz
Copy link
Contributor

knz commented Mar 20, 2023

also here https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_BazelEssentialCi/9140681?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true

@knz knz added GA-blocker branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 labels Mar 20, 2023
@blathers-crl blathers-crl bot added the T-kv KV Team label Mar 20, 2023
@cucaroach
Copy link
Contributor

TestTrace has "storage.pendingLeaseRequest: requesting lease" as an alwaysOptionalSpan, maybe something changed and that was renamed to "pendingLeaseRequest: requesting lease"? Seems to originate here:

https://github.com/cockroachdb/cockroach/blob/master/pkg/kv/kvserver/replica_range_lease.go#L374

Tagging KV team.

@aadityasondhi
Copy link
Collaborator

Had this fail on my branch: #98077

Ran locally under stress: 19 runs completed, 1 failures, over 18s. Seems to be flaky.

@abarganier abarganier self-assigned this Mar 20, 2023
@aadityasondhi aadityasondhi mentioned this issue Mar 20, 2023
Merged
@abarganier
Copy link
Contributor

Assigning to Erik, as they made a fix at: #99062. It will be merged soon.

@craig craig bot closed this as completed in 3f960e1 Mar 21, 2023
@craig craig bot closed this as completed in #99062 Mar 21, 2023
@exalate-issue-sync exalate-issue-sync bot removed the T-sql-queries SQL Queries Team label Mar 21, 2023
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). GA-blocker O-robot Originated from a bot. T-kv KV Team
Projects
SQL Queries
Archived in project
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

sql: deflake TestTrace erikgrinaker/cockroach
6 participants
@knz @erikgrinaker @abarganier @aadityasondhi @cockroach-teamcity @cucaroach