Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multitenant: Tenants started with startTenant that fail during startup are not cleaned up immediately #98868

Closed
ajstorm opened this issue Mar 17, 2023 · 1 comment · Fixed by #100436
Closed

multitenant: Tenants started with startTenant that fail during startup are not cleaned up immediately #98868

ajstorm opened this issue Mar 17, 2023 · 1 comment · Fixed by #100436
Assignees
@knz
Labels
branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-multitenant Issues owned by the multi-tenant virtual team

Comments

@ajstorm
Copy link
Collaborator

ajstorm commented Mar 17, 2023 •
edited by knz
Loading

Describe the problem

It was notice in the course of multi-tenant upgrade testing that tenants which fail during startup don't return a stopper. At the same time, they don't immediately stop. The workaround for this is to supply a custom stopper, as is done in TestServerStartupGuardrails. We should investigate why this is occurring, and fix it.

To Reproduce

Remove the custom stopper added in #94998 and rerun the test.

Jira issue: CRDB-25558
Epic: CRDB-23559
@ajstorm ajstorm added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-multitenant Issues owned by the multi-tenant virtual team release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 17, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 17, 2023

Hi @ajstorm, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@ajstorm ajstorm added the branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 label Mar 17, 2023
@knz knz added GA-blocker branch-master Failures and bugs on the master branch. and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 17, 2023
@knz knz removed the GA-blocker label Mar 27, 2023
@knz knz mentioned this issue Apr 2, 2023
Merged
@craig craig bot closed this as completed in #100436 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-multitenant Issues owned by the multi-tenant virtual team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: fix the tenant server error handling knz/cockroach
2 participants
@knz @ajstorm