Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/sqlproxyccl/acl: TestParsingErrorHandling failed #98839

Closed
cockroach-teamcity opened this issue Mar 17, 2023 · 6 comments · Fixed by #99050
Closed

ccl/sqlproxyccl/acl: TestParsingErrorHandling failed #98839

cockroach-teamcity opened this issue Mar 17, 2023 · 6 comments · Fixed by #99050
Assignees
@pjtatlow
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 17, 2023 •
edited by cockroach-jira-scripts
Loading

ccl/sqlproxyccl/acl.TestParsingErrorHandling failed with artifacts on master @ 11fbbca584e3bd774ebee3ee94c49ca30a096b26:

=== RUN   TestParsingErrorHandling
--- FAIL: TestParsingErrorHandling (0.88s)
=== RUN   TestParsingErrorHandling/error_after_update
    file_test.go:499: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl/acl/file_test.go:499
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestParsingErrorHandling/error_after_update
E230317 06:41:02.334749 97 ccl/sqlproxyccl/acl/file.go:71  [-] 14  error updating access control list from file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling1756134841/001/allowlist.yaml modified at 2023-03-17 06:41:01.450593078 +0000 UTC: yaml: unmarshal errors:
E230317 06:41:02.334749 97 ccl/sqlproxyccl/acl/file.go:71  [-] 14 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230317 06:41:02.334948 97 ccl/sqlproxyccl/acl/file.go:110  [-] 15  Could not read file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling1756134841/001/allowlist.yaml for *acl.Allowlist: yaml: unmarshal errors:
E230317 06:41:02.334948 97 ccl/sqlproxyccl/acl/file.go:110  [-] 15 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230317 06:41:02.335006 97 ccl/sqlproxyccl/acl/file.go:100  [-] 16  WatchList daemon stopped: context canceled
    --- FAIL: TestParsingErrorHandling/error_after_update (0.20s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-sessions @cockroachdb/server

This test on roachdash | Improve this report!

Jira issue: CRDB-25541
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Mar 17, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Mar 17, 2023
@cockroach-teamcity
Copy link
Member Author

ccl/sqlproxyccl/acl.TestParsingErrorHandling failed with artifacts on master @ 9aa4f3485c75397e9ce0edabbf22c6343e1a901a:

=== RUN   TestParsingErrorHandling
--- FAIL: TestParsingErrorHandling (0.41s)
=== RUN   TestParsingErrorHandling/error_after_update
    file_test.go:499: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl/acl/file_test.go:499
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestParsingErrorHandling/error_after_update
    --- FAIL: TestParsingErrorHandling/error_after_update (0.20s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

ccl/sqlproxyccl/acl.TestParsingErrorHandling failed with artifacts on master @ 5839fe0fd13aa33f247e6591875e197fa451e770:

=== RUN   TestParsingErrorHandling
--- FAIL: TestParsingErrorHandling (1.21s)
=== RUN   TestParsingErrorHandling/error_after_update
E230320 16:17:42.842486 93 ccl/sqlproxyccl/acl/file.go:71  [-] 14  error updating access control list from file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling777176561/001/allowlist.yaml modified at 2023-03-20 16:17:42.705381065 +0000 UTC: yaml: unmarshal errors:
E230320 16:17:42.842486 93 ccl/sqlproxyccl/acl/file.go:71  [-] 14 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230320 16:17:42.842650 93 ccl/sqlproxyccl/acl/file.go:110  [-] 15  Could not read file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling777176561/001/allowlist.yaml for *acl.Allowlist: yaml: unmarshal errors:
E230320 16:17:42.842650 93 ccl/sqlproxyccl/acl/file.go:110  [-] 15 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230320 16:17:42.943698 93 ccl/sqlproxyccl/acl/file.go:71  [-] 16  error updating access control list from file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling777176561/001/allowlist.yaml modified at 2023-03-20 16:17:42.705381065 +0000 UTC: yaml: unmarshal errors:
E230320 16:17:42.943698 93 ccl/sqlproxyccl/acl/file.go:71  [-] 16 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230320 16:17:42.943796 93 ccl/sqlproxyccl/acl/file.go:110  [-] 17  Could not read file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling777176561/001/allowlist.yaml for *acl.Allowlist: yaml: unmarshal errors:
E230320 16:17:42.943796 93 ccl/sqlproxyccl/acl/file.go:110  [-] 17 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230320 16:17:43.044164 93 ccl/sqlproxyccl/acl/file.go:71  [-] 18  error updating access control list from file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling777176561/001/allowlist.yaml modified at 2023-03-20 16:17:42.705381065 +0000 UTC: yaml: unmarshal errors:
E230320 16:17:43.044164 93 ccl/sqlproxyccl/acl/file.go:71  [-] 18 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230320 16:17:43.044254 93 ccl/sqlproxyccl/acl/file.go:110  [-] 19  Could not read file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling777176561/001/allowlist.yaml for *acl.Allowlist: yaml: unmarshal errors:
E230320 16:17:43.044254 93 ccl/sqlproxyccl/acl/file.go:110  [-] 19 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230320 16:17:43.144585 93 ccl/sqlproxyccl/acl/file.go:71  [-] 20  error updating access control list from file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling777176561/001/allowlist.yaml modified at 2023-03-20 16:17:42.705381065 +0000 UTC: yaml: unmarshal errors:
E230320 16:17:43.144585 93 ccl/sqlproxyccl/acl/file.go:71  [-] 20 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230320 16:17:43.144689 93 ccl/sqlproxyccl/acl/file.go:110  [-] 21  Could not read file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling777176561/001/allowlist.yaml for *acl.Allowlist: yaml: unmarshal errors:
E230320 16:17:43.144689 93 ccl/sqlproxyccl/acl/file.go:110  [-] 21 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230320 16:17:43.245050 93 ccl/sqlproxyccl/acl/file.go:71  [-] 22  error updating access control list from file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling777176561/001/allowlist.yaml modified at 2023-03-20 16:17:42.705381065 +0000 UTC: yaml: unmarshal errors:
E230320 16:17:43.245050 93 ccl/sqlproxyccl/acl/file.go:71  [-] 22 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230320 16:17:43.245143 93 ccl/sqlproxyccl/acl/file.go:110  [-] 23  Could not read file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling777176561/001/allowlist.yaml for *acl.Allowlist: yaml: unmarshal errors:
E230320 16:17:43.245143 93 ccl/sqlproxyccl/acl/file.go:110  [-] 23 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230320 16:17:43.345413 93 ccl/sqlproxyccl/acl/file.go:71  [-] 24  error updating access control list from file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling777176561/001/allowlist.yaml modified at 2023-03-20 16:17:42.705381065 +0000 UTC: yaml: unmarshal errors:
E230320 16:17:43.345413 93 ccl/sqlproxyccl/acl/file.go:71  [-] 24 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230320 16:17:43.345522 93 ccl/sqlproxyccl/acl/file.go:110  [-] 25  Could not read file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling777176561/001/allowlist.yaml for *acl.Allowlist: yaml: unmarshal errors:
E230320 16:17:43.345522 93 ccl/sqlproxyccl/acl/file.go:110  [-] 25 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
    file_test.go:517: should have gotten a new controller
    --- FAIL: TestParsingErrorHandling/error_after_update (0.89s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@rafiss
Copy link
Collaborator

rafiss commented Mar 20, 2023

Seems that this test was just added recently in a20ff9b. assigning @pjtatlow

@pjtatlow pjtatlow mentioned this issue Mar 20, 2023
Merged
@cockroach-teamcity
Copy link
Member Author

ccl/sqlproxyccl/acl.TestParsingErrorHandling failed with artifacts on master @ b806772ef6ee57b8ef40f8921ab66b3042136033:

=== RUN   TestParsingErrorHandling
--- FAIL: TestParsingErrorHandling (0.42s)
=== RUN   TestParsingErrorHandling/error_after_update
    file_test.go:499: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl/acl/file_test.go:499
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestParsingErrorHandling/error_after_update
E230321 04:02:30.228821 83 ccl/sqlproxyccl/acl/file.go:71  [-] 14  error updating access control list from file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling2337365243/001/allowlist.yaml modified at 2023-03-21 04:02:29.806762701 +0000 UTC: yaml: unmarshal errors:
E230321 04:02:30.228821 83 ccl/sqlproxyccl/acl/file.go:71  [-] 14 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230321 04:02:30.229001 83 ccl/sqlproxyccl/acl/file.go:110  [-] 15  Could not read file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling2337365243/001/allowlist.yaml for *acl.Allowlist: yaml: unmarshal errors:
E230321 04:02:30.229001 83 ccl/sqlproxyccl/acl/file.go:110  [-] 15 +  line 1: cannot unmarshal !!str ``no long...`` into acl.AllowlistFile
E230321 04:02:30.229058 83 ccl/sqlproxyccl/acl/file.go:100  [-] 16  WatchList daemon stopped: context canceled
    --- FAIL: TestParsingErrorHandling/error_after_update (0.20s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

ccl/sqlproxyccl/acl.TestParsingErrorHandling failed with artifacts on master @ b806772ef6ee57b8ef40f8921ab66b3042136033:

=== RUN   TestParsingErrorHandling
--- FAIL: TestParsingErrorHandling (0.55s)
=== RUN   TestParsingErrorHandling/error_after_update
    file_test.go:499: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl/acl/file_test.go:499
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestParsingErrorHandling/error_after_update
    --- FAIL: TestParsingErrorHandling/error_after_update (0.20s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

ccl/sqlproxyccl/acl.TestParsingErrorHandling failed with artifacts on master @ b806772ef6ee57b8ef40f8921ab66b3042136033:

=== RUN   TestParsingErrorHandling
--- FAIL: TestParsingErrorHandling (0.58s)
=== RUN   TestParsingErrorHandling/error_after_update
E230321 04:02:41.585340 86 ccl/sqlproxyccl/acl/file.go:71  [-] 13  error updating access control list from file /artifacts/tmp/_tmp/72c09b96526627cf742479f65b1af982/TestParsingErrorHandling3946405301/001/error_file.idk modified at 2023-03-21 04:02:41.582434682 +0000 UTC: yaml: unmarshal errors:
E230321 04:02:41.585340 86 ccl/sqlproxyccl/acl/file.go:71  [-] 13 +  line 1: cannot unmarshal !!str ``not yaml`` into acl.AllowlistFile
    file_test.go:499: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl/acl/file_test.go:499
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestParsingErrorHandling/error_after_update
    --- FAIL: TestParsingErrorHandling/error_after_update (0.20s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@craig craig bot closed this as completed in bef8794 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjtatlow pjtatlow

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

ccl/sqlproxyccl/acl: fix TestParsingErrorHandling flake pjtatlow/cockroach
3 participants
@rafiss @pjtatlow @cockroach-teamcity