Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: use count of encountered MVCC tombstones as GC signal #98561

Open
tbg opened this issue Mar 14, 2023 · 0 comments
Open

kvserver: use count of encountered MVCC tombstones as GC signal #98561

tbg opened this issue Mar 14, 2023 · 0 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@tbg
Copy link
Member

tbg commented Mar 14, 2023

Is your feature request related to a problem? Please describe.

See #17229 (comment). In this issue, @a-robinson ended up with a range that wasn't eligible for GC even though most of the shadowed data was GC'able, because the GC'able data represented only a small portion of the range. However, this small portion of the range was hot and so performance suffered.

Describe the solution you'd like

We could capture stats the rate at which shadowed versions are skipped and use this to influence the aggressiveness of GC. In particular, the DeadFraction1 should not lower the score when the shadowed data is read at a high rate.

Jira issue: CRDB-25331

Footnotes

  1. https://github.com/cockroachdb/cockroach/blob/736a67e0d36cc545bf74d65db069ee895ff9bea0/pkg/kv/kvserver/mvcc_gc_queue.go#L457

@tbg tbg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
None yet
Development

No branches or pull requests

1 participant