Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: triage microbenchmark regressions for v23.1 #98068

Closed
7 tasks done
nvanbenschoten opened this issue Mar 6, 2023 · 2 comments
Closed
7 tasks done

kv: triage microbenchmark regressions for v23.1 #98068

nvanbenschoten opened this issue Mar 6, 2023 · 2 comments
Labels
A-kv Anything in KV that doesn't belong in a more specific category. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-performance Perf of queries or internals. Solution not expected to change functional behavior. GA-blocker T-kv KV Team

Comments

@nvanbenschoten
Copy link
Member

nvanbenschoten commented Mar 6, 2023 •
edited
Loading

From the sneak peak of 23.1 microbenchmark results (#96960): https://docs.google.com/spreadsheets/d/10GhYr_91CANCNKOM_gPy7Sk9hQkTyQGNgNwNgfHeUtI/edit#gid=4

time/op regressions:

alloc/op regressions (ignoring duplicates from above):

allocs/op regressions (ignoring duplicates from above):

Jira issue: CRDB-25062
@nvanbenschoten nvanbenschoten added C-performance Perf of queries or internals. Solution not expected to change functional behavior. A-kv Anything in KV that doesn't belong in a more specific category. GA-blocker T-kv KV Team branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 labels Mar 6, 2023
This was referenced Mar 8, 2023
Closed
Closed
@erikgrinaker
Copy link
Contributor

FYI, repl can pick up ReplicaEngineDataIterator and BumpSideTransportClosed here, split out issues for them.

This was referenced Mar 17, 2023
Closed
Closed
Closed
Closed
Closed
@nvanbenschoten
Copy link
Member Author

Closing now that each regression has its own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-kv Anything in KV that doesn't belong in a more specific category. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-performance Perf of queries or internals. Solution not expected to change functional behavior. GA-blocker T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikgrinaker @nvanbenschoten