Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: expand gc_protect_expires_after to be applied to running changefeeds #98063

Closed
amruss opened this issue Mar 6, 2023 · 4 comments
Closed

changefeedccl: expand gc_protect_expires_after to be applied to running changefeeds #98063

amruss opened this issue Mar 6, 2023 · 4 comments
Assignees
@HonoreDB
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc

Comments

@amruss
Copy link
Contributor

amruss commented Mar 6, 2023 •
edited by exalate-issue-sync bot
Loading

gc_protect_expires_after only applies to paused changefeeds today. We would like to expand this to running changefeeds - since they will also cause unbounded lingering protected timestamps even without being paused. Note: this expiration should not be applied when running an initial scan. We should also prevent you from setting this setting very low (< 1 hour?)

Jira issue: CRDB-25451

Epic CRDB-28882
@amruss amruss added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture T-cdc labels Mar 6, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 6, 2023

cc @cockroachdb/cdc

@amruss
Copy link
Contributor Author

amruss commented Mar 8, 2023

@miretskiy looking at #97148 it seems like the expiration only applies to paused jobs, is that the case?

@miretskiy
Copy link
Contributor

Yes, that's correct.

@amruss amruss changed the title changefeedccl: restrict gc_protect_expires_after to be used with protect_data_from_gc_on_pause changefeedccl: expand gc_protect_expires_after to be applied to running changefeeds Mar 15, 2023
@miretskiy
Copy link
Contributor

Resolved via #103539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HonoreDB HonoreDB

Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HonoreDB @amruss @miretskiy