ui, server: add limit and sort to statements api request #97876
Assignees
Labels
A-sql-observability
Related to observability of the SQL layer
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
xinhaoz
added
C-bug
xinhaoz
changed the title
maryliag
pushed a commit
to maryliag/cockroach
that referenced
this issue
Mar 18, 2023
This commit adds limit and sort fields to the combined statements request. These params can be used to specify how much data is returned and the priority at which to return data (e.g. top-k). The current sort options are: - service latency - cpu time Epic: none Part of: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
maryliag
pushed a commit
to maryliag/cockroach
that referenced
this issue
Mar 18, 2023
This commit adds new knobs to the sql stats fingerprint pages. Users can now specify a limit and sort priority with their sql stats fingerprints requests. Closes: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
maryliag
pushed a commit
to maryliag/cockroach
that referenced
this issue
Mar 18, 2023
This commit adds limit and sort fields to the combined statements request. These params can be used to specify how much data is returned and the priority at which to return data (e.g. top-k). The current sort options are: - service latency - cpu time Epic: none Part of: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
maryliag
pushed a commit
to maryliag/cockroach
that referenced
this issue
Mar 18, 2023
This commit adds new knobs to the sql stats fingerprint pages. Users can now specify a limit and sort priority with their sql stats fingerprints requests. Closes: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Mar 19, 2023
This commit adds limit and sort fields to the combined statements request. These params can be used to specify how much data is returned and the priority at which to return data (e.g. top-k). The current sort options are: - service latency - cpu time - p99 (statements only) - contention time - execution count Epic: none Part of: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Mar 19, 2023
This commit adds new knobs to the sql stats fingerprint pages. Users can now specify a limit and sort priority with their sql stats fingerprints requests. Closes: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Mar 20, 2023
This commit adds new knobs to the sql stats fingerprint pages. Users can now specify a limit and sort priority with their sql stats fingerprints requests. Closes: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Mar 20, 2023
This commit adds new knobs to the sql stats fingerprint pages. Users can now specify a limit and sort priority with their sql stats fingerprints requests. Closes: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Mar 20, 2023
This commit adds new knobs to the sql stats fingerprint pages. Users can now specify a limit and sort priority with their sql stats fingerprints requests. Closes: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Mar 20, 2023
This commit adds new knobs to the sql stats fingerprint pages. Users can now specify a limit and sort priority with their sql stats fingerprints requests. Closes: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Mar 20, 2023
This commit adds limit and sort fields to the combined statements request. These params can be used to specify how much data is returned and the priority at which to return data (e.g. top-k). The current sort options are: - service latency - cpu time - p99 (statements only) - contention time - execution count Epic: none Part of: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Mar 23, 2023
This commit adds limit and sort fields to the combined statements request. These params can be used to specify how much data is returned and the priority at which to return data (e.g. top-k). The current sort options are: - service latency - contention time - execution count Epic: none Part of: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Mar 23, 2023
This commit adds new knobs to the sql stats fingerprint pages. Users can now specify a limit and sort priority with their sql stats fingerprints requests. Closes: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Apr 5, 2023
This commit adds limit and sort fields to the combined statements request. These params can be used to specify how much data is returned and the priority at which to return data (e.g. top-k). The current sort options are: - service latency - contention time - execution count Epic: none Part of: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
Apr 6, 2023
This commit adds new knobs to the sql stats fingerprint pages. Users can now specify a limit and sort priority with their sql stats fingerprints requests. Closes: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
May 15, 2023
This commit adds limit and sort fields to the combined statements request. These params can be used to specify how much data is returned and the priority at which to return data (e.g. top-k). The current sort options are: - service latency - cpu time - p99 (statements only) - contention time - execution count Epic: none Part of: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
May 16, 2023
This commit adds new knobs to the sql stats fingerprint pages. Users can now specify a limit and sort priority with their sql stats fingerprints requests. Closes: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
xinhaoz
added a commit
to xinhaoz/cockroach
that referenced
this issue
May 17, 2023
This commit adds new knobs to the sql stats fingerprint pages. Users can now specify a limit and sort priority with their sql stats fingerprints requests. Closes: cockroachdb#97876 Part of: cockroachdb#97875 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we limit the number of stats that we return to the client with a cluster setting.
This should be changed to a request parameter, with a dropdown of limit options added to the sql stats pages so that the user can specify the limit in the request. This limit is necessary to ensure we don't exceed the max response size and to improve response times.
We need to consider sorting as a part of this feature as it will probably be necesssary along with this to actually ensure we return useful data for smaller limits.
Jira issue: CRDB-24939
The text was updated successfully, but these errors were encountered: