Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: make it easier to spot mistakes in manually-entered options=-ccluster URL parameter #97586

Closed
knz opened this issue Feb 23, 2023 · 0 comments · Fixed by #97588
Closed

cli: make it easier to spot mistakes in manually-entered options=-ccluster URL parameter #97586

knz opened this issue Feb 23, 2023 · 0 comments · Fixed by #97588
Assignees
@knz
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@knz
Copy link
Contributor

knz commented Feb 23, 2023 •
edited by cockroach-jira-scripts
Loading

It's easy to mistype &options=-ccluster= in the sql conn url and instead type &-ccluster= or &--ccluster or &--cluster=. We could print out a warning/hint in that case to help the user.

Epic: CRDB-23559

Jira issue: CRDB-25255
@knz knz added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Feb 23, 2023
@knz knz mentioned this issue Feb 23, 2023
Merged
@craig craig bot closed this as completed in 4050ff2 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: warn the user for common mistakes around options=-ccluster knz/cockroach
1 participant
@knz