Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: add roachtest/workload for testing latency of ORM introspection queries #96359

Closed
rafiss opened this issue Feb 1, 2023 · 4 comments
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rafiss
Copy link
Collaborator

rafiss commented Feb 1, 2023

We have rttanalysis tests for queries made by ORMs: https://github.com/cockroachdb/cockroach/blob/067dc92538d0d433218c588187263fc93b19985d/pkg/bench/rttanalysis/testdata/benchmark_expectations

But as #96218 shows, there still can be latency regressions even if round trips don't change. We got somewhat lucky in catching that regression.

If we had latency benchmarks, we would have caught that issue more easily.

cc @dikshant

Jira issue: CRDB-24085

@rafiss rafiss added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure labels Feb 1, 2023
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Feb 1, 2023
@dikshant
Copy link

dikshant commented Apr 28, 2023

#102613 is another case that would be caught more easily if we had tests in place.

@dikshant
Copy link

Other cases are #93955 and #100871

@rafiss
Copy link
Collaborator Author

rafiss commented Jun 20, 2023

I will add this to the benchmark (from #102613)

SELECT
  current_database(), n.nspname, relname, d.description
FROM
  pg_description AS d
  INNER JOIN pg_class AS c ON d.objoid = c.oid
  INNER JOIN pg_namespace AS n ON n.oid = c.relnamespace
WHERE
  d.objsubid = 0
  AND n.nspname
    NOT IN (
        'gp_toolkit':::STRING:::NAME,
        'information_schema':::STRING:::NAME,
        'pgagent':::STRING:::NAME
      )
  AND n.nspname NOT LIKE 'pg_%';

#93955 and #100871 are already being tested.

@rafiss
Copy link
Collaborator Author

rafiss commented Jun 20, 2023

Nevermind, that query is also there already:

@rafiss rafiss closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

No branches or pull requests

2 participants