Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: make shared-process tenant servers use node certs for outgoing RPC connections #96215

Closed
knz opened this issue Jan 30, 2023 · 0 comments · Fixed by #96553
Closed

server: make shared-process tenant servers use node certs for outgoing RPC connections #96215

knz opened this issue Jan 30, 2023 · 0 comments · Fixed by #96553
Assignees
@knz
Labels
A-kv-security A-kv-server Relating to the KV-level RPC server A-multitenancy Related to multi-tenancy A-security C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@knz
Copy link
Contributor

knz commented Jan 30, 2023 •
edited by cockroach-jira-scripts
Loading

Describe the problem

Currently, outgoing RPC connections across the cluster by secondary tenant servers still require using the special "tenant client cert", to be manually minted before the tenant is created.

Since the tenant is running in the same process as the KV layer, there is no good reason for it to needs a separate cert. Having per-tenant certs in that case also makes orchestration more difficult.

Expected behavior

Outgoing RPCs from secondary tenant servers running in the same process as KV should use the same certs as KV does itself.

The solution for this requires first fixing #75795.

Epic: CRDB-23559

Jira issue: CRDB-24008
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-security A-kv-server Relating to the KV-level RPC server A-security A-multitenancy Related to multi-tenancy labels Jan 30, 2023
@knz knz mentioned this issue Feb 5, 2023
Merged
@craig craig bot closed this as completed in 75eb88d Feb 7, 2023
@exalate-issue-sync exalate-issue-sync bot reopened this Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-kv-security A-kv-server Relating to the KV-level RPC server A-multitenancy Related to multi-tenancy A-security C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc,server: use node certs for shared-process tenant RPCs knz/cockroach
1 participant
@knz