Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: don't allow cross-tenant RPCs #96150

Closed
knz opened this issue Jan 29, 2023 · 0 comments · Fixed by #96152
Closed

rpc: don't allow cross-tenant RPCs #96150

knz opened this issue Jan 29, 2023 · 0 comments · Fixed by #96152
Assignees
@knz
Labels
A-multitenancy Related to multi-tenancy A-security C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@knz
Copy link
Contributor

knz commented Jan 29, 2023 •
edited by cockroach-jira-scripts
Loading

Describe the problem

Currently a server for tenant 123 can perform RPCs to a server for tenant 456.

This is not a security issue in CC serverless, but it can result in confusing errors in tests if the test contains a mistake and a test server accidentally attempts to connect to a server run by a different test.

Expected behavior

Tenant servers should only accept RPCs by other servers running with the same tenant ID.

Epic: CRDB-23559.

Jira issue: CRDB-23968
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-security A-multitenancy Related to multi-tenancy labels Jan 29, 2023
@knz knz self-assigned this Jan 29, 2023
@knz knz mentioned this issue Jan 29, 2023
Merged
@craig craig bot closed this as completed in 10ef5d9 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-multitenancy Related to multi-tenancy A-security C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpc: prevent cross-tenant RPCs knz/cockroach
1 participant
@knz