Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: consult quota pool before lease transfer #95992

Closed
tbg opened this issue Jan 26, 2023 · 2 comments
Closed

kvserver: consult quota pool before lease transfer #95992

tbg opened this issue Jan 26, 2023 · 2 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs T-kv KV Team

Comments

@tbg
Copy link
Member

tbg commented Jan 26, 2023 •
edited by cockroach-jira-scripts
Loading

Is your feature request related to a problem? Please describe.

See https://github.com/cockroachlabs/support/issues/2008. We think the main culprit in that issue were lease transfers to nodes that ended up needing a snapshot, which should1 be fixed in 22.2 at least in the common case (and further de-risked by transferring via expiration-based leases), but it's still a bad idea to send the lease to a node that is not actively being enforced by the quota pool. If a peer is enforced by the quota pool, we shouldn't see it get cut off from the log via a log truncation either, which provides additional protection against theoretical races where the snapshot might become necessary "just after" we initiate the lease transfer.

It's possible that we'll never again see issues after #82758 is picked up by all customers.

Jira issue: CRDB-23885

Footnotes

  1. https://github.com/cockroachdb/cockroach/pull/82758 ↩
@tbg tbg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs T-kv KV Team labels Jan 26, 2023
@tbg
Copy link
Member Author

tbg commented Jul 3, 2023

This issue is obsolete if we disable/remove the quota pool, x-ref #106063

@nvanbenschoten
Copy link
Member

Closing as duplicate of #96304.

@nvanbenschoten nvanbenschoten closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
@github-project-automation github-project-automation bot moved this to Closed in KV Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs T-kv KV Team
Projects
No open projects
KV
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tbg @nvanbenschoten