Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: wrong attidentity in pg_attribute for GENERATED BY DEFAULT AS IDENTITY #95321

Closed
knz opened this issue Jan 16, 2023 · 1 comment · Fixed by #92545
Closed

sql: wrong attidentity in pg_attribute for GENERATED BY DEFAULT AS IDENTITY #95321

knz opened this issue Jan 16, 2023 · 1 comment · Fixed by #92545
Assignees
@ZhouXing19
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-vtables Virtual tables - pg_catalog, information_schema etc C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@knz
Copy link
Contributor

knz commented Jan 16, 2023 •
edited by cockroach-jira-scripts
Loading

Needed for #88061.
Found by @ZhouXing19

The value of attidentity should be d rather than b in this case.

Epic: CRDB-23454

Jira issue: CRDB-23457
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-vtables Virtual tables - pg_catalog, information_schema etc labels Jan 16, 2023
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jan 16, 2023
@knz knz mentioned this issue Jan 16, 2023
Merged
@knz
Copy link
Contributor Author

knz commented Jan 16, 2023

fixed by #92545

@knz knz closed this as completed Jan 16, 2023
@exalate-issue-sync exalate-issue-sync bot reopened this Jan 16, 2023
@exalate-issue-sync exalate-issue-sync bot removed the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jan 16, 2023
@exalate-issue-sync exalate-issue-sync bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZhouXing19 ZhouXing19

Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-vtables Virtual tables - pg_catalog, information_schema etc C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: fix attidentity for GENERATED BY DEFAULT AS IDENTITY column ZhouXing19/cockroach
2 participants
@knz @ZhouXing19