Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: audit fatal assertions and downgrade some to test builds only #94979

Open
tbg opened this issue Jan 10, 2023 · 4 comments
Open

kvserver: audit fatal assertions and downgrade some to test builds only #94979

tbg opened this issue Jan 10, 2023 · 4 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) quality-friday A good issue to work on on Quality Friday T-kv KV Team

Comments

@tbg
Copy link
Member

tbg commented Jan 10, 2023 •
edited by exalate-issue-sync bot
Loading

We have a number of assertions in production builds that will crash the node. This is often worse than the problem they're trying to prevent. We should, by default, place assertions behind buildutil.CrdbTestBuild.

See #94825 (comment) for an example.

Jira issue: CRDB-23255

Epic CRDB-40201
@tbg tbg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv-replication labels Jan 10, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jan 10, 2023

cc @cockroachdb/replication

@tbg tbg mentioned this issue Jan 10, 2023
Merged
@pav-kv
Copy link
Collaborator

pav-kv commented Jan 10, 2023

Some ideas: #94825 (comment)

@tbg
Copy link
Member Author

tbg commented Jan 10, 2023

also linking #86678 - we don't actually run with crdb_test in roachtest, so we should tag a few tests as doing so. There is some infra for this, linked in the issue.

@tbg tbg mentioned this issue Jan 10, 2023
Open
@erikgrinaker erikgrinaker added the quality-friday A good issue to work on on Quality Friday label Jul 20, 2023
@erikgrinaker
Copy link
Contributor

Use #106508 once merged.

@exalate-issue-sync exalate-issue-sync bot added T-kv KV Team and removed T-kv-replication labels Jun 28, 2024
@github-project-automation github-project-automation bot moved this to Incoming in KV Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) quality-friday A good issue to work on on Quality Friday T-kv KV Team
Projects
No open projects
KV
Status: Incoming
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erikgrinaker @pav-kv @tbg