Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug/logspy: filter logs based on tenant ID for non-system tenants. #94779

Closed
abarganier opened this issue Jan 5, 2023 · 0 comments
Closed

debug/logspy: filter logs based on tenant ID for non-system tenants. #94779

abarganier opened this issue Jan 5, 2023 · 0 comments
Assignees
@abarganier
Labels
A-observability-inf C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@abarganier
Copy link
Contributor

abarganier commented Jan 5, 2023 •
edited by exalate-issue-sync bot
Loading

/debug/logspy is an endpoint that allows users to stream newly generated logs for a given duration. It is made available in the DB Console.

With multiple tenants per-process, we need to ensure that this endpoint does not expose logs generated by other tenants when this endpoint is being served for a non-system tenant. Instead, the endpoint should filter logs based on tenant ID.

Update the endpoint to do so.

Jira issue: CRDB-23138

Epic CRDB-14486
@abarganier abarganier added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability-inf labels Jan 5, 2023
@abarganier abarganier self-assigned this Jan 5, 2023
@abarganier abarganier mentioned this issue Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abarganier abarganier

Labels
A-observability-inf C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abarganier