Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: TenantHTTPClient should be usable from multiple subtests #93267

Closed
matthewtodd opened this issue Dec 8, 2022 · 0 comments
Closed

test: TenantHTTPClient should be usable from multiple subtests #93267

matthewtodd opened this issue Dec 8, 2022 · 0 comments
Labels
A-sql-observability Related to observability of the SQL layer C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@matthewtodd
Copy link
Contributor

matthewtodd commented Dec 8, 2022

In testing #93268 I ran into trouble using TenantClusterHelper.TenantHTTPClient() from multiple subtests. My test failed with an error about the SQL user authentic_user_noadmin already existing, but as far as I can tell the sync.Once mechanism in its setup should have protected me from that.

I'd like to make a minimally-reproducing test case to figure it out, rather than further holding up that other work.

Jira issue: CRDB-22252

@matthewtodd matthewtodd added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-observability Related to observability of the SQL layer T-sql-observability labels Dec 8, 2022
@matthewtodd matthewtodd self-assigned this Dec 8, 2022
@matthewtodd matthewtodd removed their assignment Dec 19, 2022
@maryliag maryliag closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-observability Related to observability of the SQL layer C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

No branches or pull requests

2 participants