Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loqrecovery: update roachtest to include half-online recovery #93055

Closed
aliher1911 opened this issue Dec 5, 2022 · 3 comments · Fixed by #96667
Closed

loqrecovery: update roachtest to include half-online recovery #93055

aliher1911 opened this issue Dec 5, 2022 · 3 comments · Fixed by #96667
Assignees
@aliher1911
Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@aliher1911
Copy link
Contributor

aliher1911 commented Dec 5, 2022 •
edited by exalate-issue-sync bot
Loading

Update roachtest according to new behaviour described in RFC.

Test should:

  • kill "failed" nodes
  • plan changes
  • apply plan
  • do rolling restart
  • wait for verify to report success (or failure)

Test: roachtest/tests/loss_of_quorum_recovery

Part of #77273

Jira issue: CRDB-22138

Epic CRDB-14205
@aliher1911 aliher1911 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-replication Relating to Raft, consensus, and coordination. T-kv-replication labels Dec 5, 2022
@blathers-crl
Copy link

blathers-crl bot commented Dec 5, 2022

cc @cockroachdb/replication

@erikgrinaker
Copy link
Contributor

We should have at least three variants of this: offline recovery, half-online recovery, and half-online without meta ranges.

@aliher1911
Copy link
Contributor Author

I was thinking that we could achieve that by just varying number of nodes and system ranges replication factor. Should be pretty straightforward.

@aliher1911 aliher1911 mentioned this issue Feb 6, 2023
Merged
@craig craig bot closed this as completed in a24b178 Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aliher1911 aliher1911

Labels
A-kv-replication Relating to Raft, consensus, and coordination. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest,loqrecovery: half-online loss of quorum recovery aliher1911/cockroach
3 participants
@erikgrinaker @aliher1911 and others