Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamingccl: lint failure on deprecation warning #92761

Closed
HonoreDB opened this issue Nov 30, 2022 · 3 comments · Fixed by #92760
Closed

streamingccl: lint failure on deprecation warning #92761

HonoreDB opened this issue Nov 30, 2022 · 3 comments · Fixed by #92760
Assignees
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). T-disaster-recovery

Comments

@HonoreDB
Copy link
Contributor

HonoreDB commented Nov 30, 2022

lint_test.go:1751:
pkg/ccl/streamingccl/streamclient/partitioned_stream_client_test.go:14:2: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (SA1019)
--- FAIL: TestLint/TestStaticCheck (974.77s)

Jira issue: CRDB-21955

@HonoreDB HonoreDB added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). T-disaster-recovery A-tenant-streaming Including cluster streaming labels Nov 30, 2022
@blathers-crl
Copy link

blathers-crl bot commented Nov 30, 2022

cc @cockroachdb/tenant-streaming

@blathers-crl
Copy link

blathers-crl bot commented Nov 30, 2022

cc @cockroachdb/disaster-recovery

@shermanCRL shermanCRL removed the A-tenant-streaming Including cluster streaming label Nov 30, 2022
@andyyang890
Copy link
Collaborator

I actually just opened #92760 to fix this so I'll claim this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). T-disaster-recovery
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants