logictestccl: leaked goroutine in fakedist-disk test

[cockroach-teamcity]

pkg/ccl/logictestccl/tests/fakedist-disk/fakedist-disk_test.TestCCLLogic_show_create failed with artifacts on master @ 1a6e9f885baa124d5ff2996adb966ea15a1a9b2b:

=== RUN   TestCCLLogic_show_create
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/effab48683274210e068775452544fff/logTestCCLLogic_show_create2055064146
    test_log_scope.go:79: use -show-logs to present logs inline
*
* INFO: Running test with the default test tenant. If you are only seeing a test case failure when this message appears, there may be a problem with your test case running within tenants.
*
*
* INFO: Running test with the default test tenant. If you are only seeing a test case failure when this message appears, there may be a problem with your test case running within tenants.
*
*
* INFO: Running test with the default test tenant. If you are only seeing a test case failure when this message appears, there may be a problem with your test case running within tenants.
*
[06:30:34] --- done: /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/2360/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/ccl/logictestccl/tests/fakedist-disk/fakedist-disk_test_/fakedist-disk_test.runfiles/com_github_cockroachdb_cockroach/pkg/ccl/logictestccl/testdata/logic_test/show_create with config fakedist-disk: 8 tests, 0 failures
[06:30:35] --- total progress: 8 statements
--- total: 8 tests, 0 failures
    logic.go:4129: -- test log scope end --
    generated_test.go:108: Leaked goroutine: goroutine 44112 [select]:
        github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFS).startTickerLocked.func1()
        	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:302 +0xe5
        created by github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFS).startTickerLocked
        	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:297 +0x7a
--- FAIL: TestCCLLogic_show_create (8.16s)

Parameters: TAGS=bazel,gss

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-21817

Epic CRDB-20293

[cucaroach]

Storage peeps, is there any way to know who is leaking the FS associated with a disk health checker?

[nicktrav]

is there any way to know who is leaking the FS associated with a disk health checker?

Not to my knowledge. It looks like it only gives you the one created frame. Perhaps the leak check infrastructure could show more? Though from what I gather, the goroutine output typically just show the one created frame too.

I'm hoping that this is related to #92903, which has a proposed fix. This one is rather hard to reproduce though, so I can't be certain.

[yuzefovich]

I think it's very likely that #92903 has the same root cause as this issue, so I'll make #93214 close this when merging.