Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: TestBehaviorDuringLeaseTransfer is flaky #91948

Closed
andrewbaptist opened this issue Nov 15, 2022 · 1 comment · Fixed by #98998
Closed

kv: TestBehaviorDuringLeaseTransfer is flaky #91948

andrewbaptist opened this issue Nov 15, 2022 · 1 comment · Fixed by #98998
Assignees
@shralex
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. skipped-test T-kv KV Team

Comments

@andrewbaptist
Copy link
Collaborator

andrewbaptist commented Nov 15, 2022 •
edited by cockroach-jira-scripts
Loading

Failed at least two times recently:
https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_PostMerge_MergedBazelExtendedCi/7528653?showRootCauses=true&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true

https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_PostMerge_MergedBazelExtendedCi/7527336?showRootCauses=true&expandBuildChangesSection=true&expandBuildProblemsSection=true&expandBuildTestsSection=true

Jira issue: CRDB-21501
@andrewbaptist andrewbaptist added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Nov 15, 2022
andrewbaptist added a commit to andrewbaptist/cockroach that referenced this issue Nov 15, 2022
@andrewbaptist
kv/kvserver: skip TestBehaviorDuringLeaseTransfer
10fd885 
Refs: cockroachdb#91948

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@andrewbaptist andrewbaptist mentioned this issue Nov 15, 2022
Merged
craig bot pushed a commit that referenced this issue Nov 16, 2022
@andrewbaptist @yuzefovich
Merge #91934 #91949 #91967
8a3ee4b 
91934: catalog,tabledesc: tighten Constraint interface definition r=postamar a=postamar

Informs #91918.

Release note: None

91949: kv/kvserver: skip TestBehaviorDuringLeaseTransfer r=knz a=andrewbaptist

Informs: #91948

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

91967: distsql: add flow ID tag earlier r=yuzefovich a=yuzefovich

This allows the tag to be correctly picked up by the asynchronous components (e.g. outboxes) that are created in the `Setup` method.

Epic: None

Release note: None

Co-authored-by: Marius Posta <[email protected]>
Co-authored-by: Andrew Baptist <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
@blathers-crl blathers-crl bot added the T-kv KV Team label Nov 17, 2022
@blathers-crl
Copy link

blathers-crl bot commented Mar 1, 2023

Hi @nvanbenschoten, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@nvanbenschoten nvanbenschoten added the branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 label Mar 2, 2023
shralex added a commit to shralex/cockroach that referenced this issue Mar 19, 2023
@shralex
kvserver: unskip TestBehaviorDuringLeaseTransfer
5a8a809 
Unskip this test, its not failing locally. Previous teamcity logs
are no longer available.

Epic: https://cockroachlabs.atlassian.net/browse/CRDB-21501
Fixes: cockroachdb#91948
Release note: None
@shralex shralex mentioned this issue Mar 19, 2023
Merged
@shralex shralex closed this as completed Mar 19, 2023
craig bot pushed a commit that referenced this issue Mar 21, 2023
@knz @shralex
Merge #98993 #98998
b806772 
98993: jobs: enhance the InfoStorage API r=adityamaru a=knz

Needed for #98459.
Epic: CRDB-23559

98998: kvserver: unskip TestBehaviorDuringLeaseTransfer r=shralex a=shralex

Unskip this test, its not failing locally. Previous teamcity logs are no longer available.

Epic: https://cockroachlabs.atlassian.net/browse/CRDB-21501
Fixes: #91948
Release note: None

Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: shralex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shralex shralex

Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. skipped-test T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver: unskip TestBehaviorDuringLeaseTransfer shralex/cockroach
3 participants
@nvanbenschoten @shralex @andrewbaptist