Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: investigate the discrepancy between memory monitoring metrics #91787

Closed
yuzefovich opened this issue Nov 12, 2022 · 0 comments · Fixed by #99887
Closed

sql: investigate the discrepancy between memory monitoring metrics #91787

yuzefovich opened this issue Nov 12, 2022 · 0 comments · Fixed by #99887
Assignees
@yuzefovich
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Nov 12, 2022 •
edited
Loading

Consider the following graph which shows sql.mem.distsql.current (higher) and sql.mem.root.current (lower):
Screen Shot 2022-11-11 at 6 13 58 PM

The relationship seems backwards: root monitor is an ancestor to distsql monitor, so the former should not be lower than the latter. This reproduction was obtained when running TPCH Q20 with high concurrency although I'd guess we could repro it without the concurrency.

Jira issue: CRDB-21426
@yuzefovich yuzefovich added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Nov 12, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Nov 12, 2022
@yuzefovich yuzefovich mentioned this issue Mar 29, 2023
Merged
@yuzefovich yuzefovich self-assigned this Mar 29, 2023
@craig craig bot closed this as completed in 37ac1e5 Mar 30, 2023
@blathers-crl blathers-crl bot mentioned this issue Mar 30, 2023
Merged
@yuzefovich yuzefovich mentioned this issue Mar 31, 2023
Merged
@blathers-crl blathers-crl bot mentioned this issue Apr 12, 2023
Closed
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

distsql: fix sql.mem.distsql.current metric yuzefovich/cockroach
1 participant
@yuzefovich