Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo: ctrl-c crashes demo with --no-line-editor #90653

Closed
andreimatei opened this issue Oct 25, 2022 · 0 comments · Fixed by #90689
Closed

demo: ctrl-c crashes demo with --no-line-editor #90653

andreimatei opened this issue Oct 25, 2022 · 0 comments · Fixed by #90689
Assignees
@knz
Labels
A-cli-server CLI commands that pertain to CockroachDB server processes A-demo C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-server-and-security DB Server & Security

Comments

@andreimatei
Copy link
Contributor

andreimatei commented Oct 25, 2022 •
edited by cockroach-jira-scripts
Loading 

./cockroach demo --no-line-editor 

CTRL-C

[email protected]:26257/movr> ^C
attempting to cancel query...
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x429c844]

goroutine 5111 [running]:
github.com/cockroachdb/cockroach/pkg/cli/clisqlshell.(*cliState).maybeHandleInterrupt.func2()
        github.com/cockroachdb/cockroach/pkg/cli/clisqlshell/sql.go:2366 +0x1c4
created by github.com/cockroachdb/cockroach/pkg/cli/clisqlshell.(*cliState).maybeHandleInterrupt
        github.com/cockroachdb/cockroach/pkg/cli/clisqlshell/sql.go:2344 +0x118

Jira issue: CRDB-20871
@andreimatei andreimatei added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-demo A-cli-server CLI commands that pertain to CockroachDB server processes labels Oct 25, 2022
@blathers-crl blathers-crl bot added the T-server-and-security DB Server & Security label Oct 25, 2022
@knz knz mentioned this issue Oct 26, 2022
Merged
@craig craig bot closed this as completed in f64c283 Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-cli-server CLI commands that pertain to CockroachDB server processes A-demo C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-server-and-security DB Server & Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clisqlshell: fix the behavior of ctrl+c under --no-line-editor knz/cockroach
2 participants
@andreimatei @knz