Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: stop using internal executor for rangelog #89164

Closed
ajwerner opened this issue Oct 3, 2022 · 0 comments · Fixed by #89623
Closed

kvserver: stop using internal executor for rangelog #89164

ajwerner opened this issue Oct 3, 2022 · 0 comments · Fixed by #89623
Assignees
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Oct 3, 2022

Is your feature request related to a problem? Please describe.
The rangelog table is written as part of the change replicas protocol. It can be useful for debugging. The implementation currently leverages the internal executor. In fact, it's the only use of the internal executor by kvserver at this point (AFAICT). It is problematic because we'd like the system database to be more like a regular database in terms of mutability. Today we cannot use leasing infrastructure for certain system tables because they are used by the internal executor which in turn is used by kvserver which starts up before that other infrastructure.

Describe the solution you'd like

We can inject a much narrower interface into kvserver for writing eventlog entries and we can implement it using KV client APIs and lower-level sql encodings. In this way, we'll remove the bootstrapping dependency on sql-layer services.

Describe alternatives you've considered
We could stop writing rangelogs synchronously altogether, and we may, but either way we should break this dependency.

Additional context

This will resolve #35293.

Epic: CRDB-18596

Jira issue: CRDB-20156

@ajwerner ajwerner added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Oct 3, 2022
@ajwerner ajwerner self-assigned this Oct 3, 2022
@craig craig bot closed this as completed in 2a9f158 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant