Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colexec: make sure nulls are set for datum columns #88418

Closed
DrewKimball opened this issue Sep 21, 2022 · 1 comment
Closed

colexec: make sure nulls are set for datum columns #88418

DrewKimball opened this issue Sep 21, 2022 · 1 comment
Assignees
@DrewKimball
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team

Comments

@DrewKimball
Copy link
Collaborator

DrewKimball commented Sep 21, 2022 •
edited by cockroach-jira-scripts
Loading

There are some places (for example, ConcatDatumDatum) where it is possible to set a datum value to tree.DNull without updating the Nulls bitmap. We rely on Nulls being set for any null value, so this could break things elsewhere. For projection operators that write to a datum-backed vector, we should iterate through the vector and ensure that Nulls reflects all null values. This fix is on the conservative side, but will only affect datum-backed types and the impact should be small.

Jira issue: CRDB-19809
@DrewKimball DrewKimball added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Sep 21, 2022
@DrewKimball DrewKimball self-assigned this Sep 21, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Sep 21, 2022
@DrewKimball
Copy link
Collaborator Author

Actually, #55316 should have fixed this for all datum-backed projections, not just json fetch value operators.

@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DrewKimball DrewKimball

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DrewKimball