Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: extract the call to startSampleEnvironment() from StartTenant/StartServer [CRDB-14537 followup] #84589

Closed
Tracked by #91282
knz opened this issue Jul 18, 2022 · 0 comments · Fixed by #96168
Closed
Tracked by #91282

server: extract the call to startSampleEnvironment() from StartTenant/StartServer [CRDB-14537 followup] #84589

knz opened this issue Jul 18, 2022 · 0 comments · Fixed by #96168
Assignees
@knz
Labels
A-multitenancy Related to multi-tenancy C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-multitenant Issues owned by the multi-tenant virtual team

Comments

@knz
Copy link
Contributor

knz commented Jul 18, 2022 •
edited by cockroach-jira-scripts
Loading

The function startSampleEnvironment() starts the logic that collects goroutine dumps / heap profiles etc.

This logic is process-wide and thus not specific to just 1 tenant.

Currently the call is made from inside startTenantInternal() (because the code in cli/mt_start_sql.go doesn't have another way to call it). This is illogical.

We need to remove it from there when running multiple tenants in-memory.

Epic: CRDB-14537

Jira issue: CRDB-17752
@knz knz added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Jul 18, 2022
@knz knz mentioned this issue Jul 18, 2022
Merged
@knz knz mentioned this issue Nov 4, 2022
Closed
19 tasks
@knz knz added A-multitenancy Related to multi-tenancy T-multitenant Issues owned by the multi-tenant virtual team labels Jan 10, 2023
@knz knz mentioned this issue Jan 30, 2023
Merged
@craig craig bot closed this as completed in c410d8d Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
A-multitenancy Related to multi-tenancy C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-multitenant Issues owned by the multi-tenant virtual team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: sanitize the behavior of runtime stats sampling / dumps for secondary tenants knz/cockroach
1 participant
@knz