Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SQL grammar diagram generation from Makefile to Bazel #84443

Closed
nickvigilante opened this issue Jul 14, 2022 · 2 comments · Fixed by #84451
Closed

Move SQL grammar diagram generation from Makefile to Bazel #84443

nickvigilante opened this issue Jul 14, 2022 · 2 comments · Fixed by #84451
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf

Comments

@nickvigilante
Copy link
Contributor

nickvigilante commented Jul 14, 2022

In order to successfully remove the Makefile, we have to move the SQL grammar diagram generation process from make to dev.

Similar example for reference: #83727

Jira issue: CRDB-17661

Epic CRDB-8349

@nickvigilante nickvigilante added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jul 14, 2022
@ajwerner
Copy link
Contributor

I was going to say this is really straightforward and type steps but it turned out to be just as easy to type the change: #84451.

@ajwerner
Copy link
Contributor

FYI, the generation is shockingly slow and I don't know why. There may be more tweaking required.

@craig craig bot closed this as completed in 7191d81 Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants