Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: add verify_backup_table_data option to RESTORE #83671

Closed
msbutler opened this issue Jun 30, 2022 · 2 comments
Closed

backupccl: add verify_backup_table_data option to RESTORE #83671

msbutler opened this issue Jun 30, 2022 · 2 comments
Assignees
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery

Comments

@msbutler
Copy link
Collaborator

msbutler commented Jun 30, 2022

Currently the only way for a user to validate a RESTORE cmd is by running the actual RESTORE, which can be quite expensive and time consuming.

One solution to the problem is RESTORE ... with schema_only ( #83470 ) which only restores the schema stored in the backup. In other words, no table data is read or written from external storage, aside from the manifest.

Some users may also want to validate that the actual table data is not corrupt, which would require reading data from external storage. To that end, Restore should have an additional verify_backup_table_data flag, specified with schema_only, that will read table data from external storage, conduct checksums, but will not ingest the data to cockroach. By avoiding ingestion, RESTORE ... with schema_only, verify_backup_table_data will be significantly faster than a regular restore.

Jira issue: CRDB-17201

Epic CRDB-10342

@msbutler msbutler added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-disaster-recovery T-disaster-recovery labels Jun 30, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jun 30, 2022

cc @cockroachdb/bulk-io

@msbutler msbutler self-assigned this Jun 30, 2022
@msbutler
Copy link
Collaborator Author

closed by #86136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant