Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: crash with \statement-diag list in demo #83546

Closed
yuzefovich opened this issue Jun 28, 2022 · 0 comments · Fixed by #86484
Closed

cli: crash with \statement-diag list in demo #83546

yuzefovich opened this issue Jun 28, 2022 · 0 comments · Fixed by #86484
Assignees
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Jun 28, 2022

If I spin up a demo on e19d98d, and do this:

SELECT crdb_internal.request_statement_bundle('SELECT _', 0::FLOAT, 0::INTERVAL, 0::INTERVAL);
SELECT 1;

so that a single stmt bundle is collected and then try to see the available bundles with \statement-diag list, the CLI crashes:

*
* ERROR: a panic has occurred!
* interface conversion: driver.Value is string, not int64
* (1) attached stack trace
*   -- stack trace:
*   | github.com/cockroachdb/cockroach/pkg/cli/clisqlclient.stmtDiagListBundlesInternal
*   | 	github.com/cockroachdb/cockroach/pkg/cli/clisqlclient/statement_diag.go:64
*   | github.com/cockroachdb/cockroach/pkg/cli/clisqlclient.StmtDiagListBundles
*   | 	github.com/cockroachdb/cockroach/pkg/cli/clisqlclient/statement_diag.go:36
*   | github.com/cockroachdb/cockroach/pkg/cli/clisqlshell.(*cliState).statementDiagList
*   | 	github.com/cockroachdb/cockroach/pkg/cli/clisqlshell/statement_diag.go:80
*   | github.com/cockroachdb/cockroach/pkg/cli/clisqlshell.(*cliState).handleStatementDiag
*   | 	github.com/cockroachdb/cockroach/pkg/cli/clisqlshell/statement_diag.go:40

Jira issue: CRDB-17135

@yuzefovich yuzefovich added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Jun 28, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Jun 28, 2022
@rytaft rytaft added branch-master Failures and bugs on the master branch. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Aug 4, 2022
@knz knz self-assigned this Aug 22, 2022
@craig craig bot closed this as completed in 9bd5bb0 Sep 7, 2022
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants