Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: avoid logging messages when failed to decode tableID for pseudo ranges in status.HotRangesV2 endpoint #83117

Closed
koorosh opened this issue Jun 21, 2022 · 0 comments · Fixed by #83120
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@koorosh
Copy link
Collaborator

koorosh commented Jun 21, 2022

Describe the problem

status.HotRangesV2 endopoint logs warning message when it fails to decode table ID from range's key, and
one of the reasons - this key belongs to real table (pseudo) range that doesn't have table descriptor.

Expected behavior
It is expected behavior and should be ignored without logging warning message.

Additional context

cockroach/pkg/server/status.go

Lines 2415 to 2419 in 377b113

_, tableID, err := s.sqlServer.execCfg.Codec.DecodeTablePrefix(r.Desc.StartKey.AsRawKey())
if err != nil {
log.Warningf(ctx, "cannot decode tableID for range descriptor: %s. %s", r.Desc.String(), err.Error())
continue
}

Jira issue: CRDB-16871

@koorosh koorosh added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv-observability labels Jun 21, 2022
@craig craig bot closed this as completed in 05e3d5d Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant