Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show ranges from table could be serving a user with a misleading info #82995

Closed
a-entin opened this issue Jun 16, 2022 · 0 comments · Fixed by #93545
Closed

show ranges from table could be serving a user with a misleading info #82995

a-entin opened this issue Jun 16, 2022 · 0 comments · Fixed by #93545
Assignees
@knz
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@a-entin
Copy link

a-entin commented Jun 16, 2022 •
edited by knz
Loading

Describe the problem

TLDR; A user may be intuitively expecting all ranges that have keys related to the table. But it does not include ranges for the secondary indexes.

More:

show ranges from table foo is exactly equivalent to show ranges from index foo@primary.
I.e. it does not include show ranges from index foo@secondary_idx. Seems counterintuitive and most likely not what a user would expect.

Suggested resolution:
show ranges from table should return a superset of all ranges across all indexes, not just PK. Otherwise a justification for having show ranges from table when there is show ranges from index is not clear.

Jira issue: CRDB-16785

Epic CRDB-22701
@a-entin a-entin added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Jun 16, 2022
@knz knz mentioned this issue Dec 13, 2022
Merged
@craig craig bot closed this as completed in a30fb14 Dec 14, 2022
@exalate-issue-sync exalate-issue-sync bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: make SHOW RANGES FOR TABLE include all indexes knz/cockroach
2 participants
@knz @a-entin