Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvstreamer: support pipelining of Enqueue and GetResults calls #82163

Open
Tracked by #54680
yuzefovich opened this issue May 31, 2022 · 1 comment
Open
Tracked by #54680

kvstreamer: support pipelining of Enqueue and GetResults calls #82163

yuzefovich opened this issue May 31, 2022 · 1 comment
Labels
C-performance Perf of queries or internals. Solution not expected to change functional behavior. T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented May 31, 2022

Currently, the contract of the streamer is such that the caller must fully exhaust all results produced for a single batch of enqueued requests. We should lift that restriction which will allow us to making the usage of the streamer even more "streaming" in its nature - the caller would continuously enqueue new requests, and the streamer would decide when to send BatchRequests (when they get large enough). This should give us nice performance improvements.

Jira issue: CRDB-16231

@yuzefovich yuzefovich added the C-performance Perf of queries or internals. Solution not expected to change functional behavior. label May 31, 2022
@yuzefovich yuzefovich self-assigned this May 31, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label May 31, 2022
@yuzefovich yuzefovich removed their assignment Jul 7, 2022
@mgartner mgartner moved this to Backlog (DO NOT ADD NEW ISSUES) in SQL Queries Jul 24, 2023
Copy link

github-actions bot commented Jan 1, 2024

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@yuzefovich yuzefovich moved this from Backlog (DO NOT ADD NEW ISSUES) to New Backlog in SQL Queries Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-performance Perf of queries or internals. Solution not expected to change functional behavior. T-sql-queries SQL Queries Team
Projects
Status: Backlog
Development

No branches or pull requests

1 participant