PPC64LE - pkg/geo/geomfn - TestSegmentize/GEOMETRYCOLLECTION_ - Test failures due to floating point differences #81745

prashantkhoje · 2022-05-24T14:20:37Z

Describe the problem

I built the latest (Latest commit 48e48db) cockroachdb from master branch.
When tests are run, test TestSegmentize/GEOMETRYCOLLECTION_ fails due to floating point precision differences.

To Reproduce
Build script used:

DISTRO=linux-ppc64le
GO_DISTRO=linux-ppc64le

# Install all dependencies
dnf install -y git cmake make gcc-c++ autoconf ncurses-devel libarchive curl \
wget openssl-devel diffutils procps-ng libarchive xz python2

dnf install -y \ http://rpmfind.net/linux/centos/8-stream/AppStream/ppc64le/os/Packages/bison-3.0.4-10.el8.ppc64le.rpm `
http://rpmfind.net/linux/epel/8/Everything/ppc64le/Packages/c/ccache-3.7.7-1.el8.ppc64le.rpm

cd $HOME

# Install nodejs
NODE_VERSION=v12.20.2
wget https://nodejs.org/dist/$NODE_VERSION/node-$NODE_VERSION-$DISTRO.tar.gz
tar -xzf node-$NODE_VERSION-$DISTRO.tar.gz
export PATH=$HOME/node-$NODE_VERSION-$DISTRO/bin:$PATH

npm install yarn --global

cd $HOME

# Setup go environment and install go
GOPATH=$HOME/go
GO_VERSION=1.17.8
COCKROACH_HOME=$GOPATH/src/github.com/cockroachdb
mkdir -p $COCKROACH_HOME
export GOPATH
curl -O https://dl.google.com/go/go$GO_VERSION.$GO_DISTRO.tar.gz
tar -C /usr/local -xzf go$GO_VERSION.$GO_DISTRO.tar.gz
rm -rf go$GO_VERSION.$GO_DISTRO.tar.gz
export PATH=$PATH:/usr/local/go/bin

# Clone cockroach and build
COCKROACH_VERSION=master
cd $COCKROACH_HOME
git clone https://github.com/cockroachdb/cockroach.git
cd cockroach
git checkout $COCKROACH_VERSION
make buildshort
export GOMAXPROCS=4
make test PKG=./pkg/geo/geomfn TESTFLAGS='-v -count=1' GOFLAGS='-p 1' IGNORE_GOVERS=1

Expected behavior
Tests should pass on ppc64le considering floating point differences on platforms.

Additional data / screenshots

=== RUN   TestSegmentize/GEOMETRYCOLLECTION_(POINT_(40.0_10.0),_LINESTRING_(10.0_10.0,_20.0_20.0,_10.0_40.0),_POLYGON_((40.0_40.0,_20.0_45.0,_45.0_30.0,_40.0_40.0))),_maximum_segment_length:_10.000000
    segmentize_test.go:158:
                Error Trace:    segmentize_test.go:158
                Error:          Not equal:
                                expected: geo.Geometry{spatialObject:geopb.SpatialObject{Type:2, EWKB:geopb.EWKB{0x1, 0x7, 0x0, 0x0, 0x0, 0x3, 0x0, 0x0, 0x0, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x24, 0x40, 0x1, 0x2, 0x0, 0x0, 0x0, 0x6, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x24, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x24, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x2e, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x2e, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x34, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x34, 0x40, 0xab, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x30, 0x40, 0xab, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x3a, 0x40, 0xab, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x2a, 0x40, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x40, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x24, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40, 0x1, 0x3, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x9, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40, 0xab, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x40, 0x40, 0x56, 0x55, 0x55, 0x55, 0x55, 0xd5, 0x44, 0x40, 0xab, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x3a, 0x40, 0xab, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x45, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x34, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x80, 0x46, 0x40, 0x56, 0x55, 0x55, 0x55, 0x55, 0x55, 0x3c, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40, 0x56, 0x55, 0x55, 0x55, 0x55, 0x55, 0x42, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x80, 0x41, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x80, 0x46, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x3e, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x40, 0x45, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x80, 0x41, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40}, SRID:0, ShapeType:8, BoundingBox:(*geopb.BoundingBox)(0xc000cc7ea0)}}
                                actual  : geo.Geometry{spatialObject:geopb.SpatialObject{Type:2, EWKB:geopb.EWKB{0x1, 0x7, 0x0, 0x0, 0x0, 0x3, 0x0, 0x0, 0x0, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x24, 0x40, 0x1, 0x2, 0x0, 0x0, 0x0, 0x6, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x24, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x24, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x2e, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x2e, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x34, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x34, 0x40, 0xab, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x30, 0x40, 0xab, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x3a, 0x40, 0xab, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x2a, 0x40, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x40, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x24, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40, 0x1, 0x3, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x9, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40, 0xab, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x40, 0x40, 0x56, 0x55, 0x55, 0x55, 0x55, 0xd5, 0x44, 0x40, 0xab, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x3a, 0x40, 0xab, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0x45, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x34, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x80, 0x46, 0x40, 0x56, 0x55, 0x55, 0x55, 0x55, 0x55, 0x3c, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40, 0x55, 0x55, 0x55, 0x55, 0x55, 0x55, 0x42, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x80, 0x41, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x80, 0x46, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x3e, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x40, 0x45, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x80, 0x41, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x44, 0x40}, SRID:0, ShapeType:8, BoundingBox:(*geopb.BoundingBox)(0xc000cc7c60)}}

                                Diff:
                                --- Expected
                                +++ Actual
                                @@ -18,3 +18,3 @@
                                    000000d0  00 80 46 40 56 55 55 55  55 55 3c 40 00 00 00 00  |..F@VUUUUU<@....|
                                -   000000e0  00 00 44 40 56 55 55 55  55 55 42 40 00 00 00 00  |..D@VUUUUUB@....|
                                +   000000e0  00 00 44 40 55 55 55 55  55 55 42 40 00 00 00 00  |..D@UUUUUUB@....|
                                    000000f0  00 80 41 40 00 00 00 00  00 80 46 40 00 00 00 00  |[email protected]@....|
                Test:           TestSegmentize/GEOMETRYCOLLECTION_(POINT_(40.0_10.0),_LINESTRING_(10.0_10.0,_20.0_20.0,_10.0_40.0),_POLYGON_((40.0_40.0,_20.0_45.0,_45.0_30.0,_40.0_40.0))),_maximum_segment_length:_10.000000

Environment:

CockroachDB version [22.x]

[[email protected] cockroach]# git log -3 --oneline
48e48db89e (HEAD -> master, origin/staging, origin/master, origin/HEAD) Merge #81681
7ad29c34e0 colexecwindow: fix panic when lead or lag arguments are different types
a8d4ce6cad Merge #81670 #81672
[[email protected] cockroach]# git branch
* master

Server OS: RHEL UBI 8.5
Go
[[email protected] cockroach]# go version
go version go1.17.8 linux/ppc64le
Node
[[email protected] cockroach]# node --version
v12.20.2

Additional context
We support running cockroachdb on ppc64le. We'd like to fix the failures we encounter in order to automate builds for ppc64le.

Jira issue: CRDB-16054

The text was updated successfully, but these errors were encountered:

blathers-crl · 2022-05-24T14:20:49Z

Hello, I am Blathers. I am here to help you get the issue triaged.

Hoot - a bug! Though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here.

I have CC'd a few people who may be able to assist you:

@cameronnunez (author of cloud: bump orchestrator to v22.1.0 #81670, author of roachtest: update 22.2 version map to v22.1.0 #81672)
@cockroachdb/bulk-io (found keywords: export)

If we have not gotten back to your issue within a few business days, you can try the following:

Join our community slack channel and ask on #cockroachdb.
Try find someone from here if you know they worked closely on the area and CC them.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

blathers-crl · 2022-05-24T14:20:55Z

cc @cockroachdb/bulk-io

adityamaru · 2022-05-24T14:24:12Z

cc: @otan to route correctly since I'm not sure where we track geospatial bugs.

otan · 2022-05-24T17:23:22Z

hey @prashantkhoje, we don't really support PPC64LE officially, but i'll accept patches to fix this if you are willing to make them. we probably have to make these accept a tolerable bound.

you can choose to revive #66621 if you'd like :)

otan · 2022-05-24T17:24:13Z

marking as dupe of #72225

prashantkhoje · 2022-05-25T06:36:59Z

hey @prashantkhoje, we don't really support PPC64LE officially, but i'll accept patches to fix this if you are willing to make them. we probably have to make these accept a tolerable bound.

you can choose to revive #66621 if you'd like :)

Yes. I'd be contributing patches.
Since these issues are already closed, should i create new issues for other failures i've seen before submitting patches?

otan · 2022-05-25T13:48:06Z

You don't have to - patches directly are fine. Or you can create a big issue rather than one per test failure if that helps you.

prashantkhoje · 2022-05-30T04:16:04Z

Fixed by #81894

prashantkhoje added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label May 24, 2022

blathers-crl bot added A-disaster-recovery O-community Originated from the community X-blathers-triaged blathers was able to find an owner T-disaster-recovery labels May 24, 2022

adityamaru added A-spatial Spatial work that is *not* related to builtins. and removed A-disaster-recovery labels May 24, 2022

blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 24, 2022

otan closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2022

This was referenced May 24, 2022

PPC64LE - pkg/geo/geomfn - TestGenerateRandomPoints/Polygon_with_a_hole - Test failures due to floating point differences #81741

Closed

PPC64LE - pkg/geo - TestBoundingBoxFromGeomT - Test failures due to floating point differences #81733

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PPC64LE - pkg/geo/geomfn - TestSegmentize/GEOMETRYCOLLECTION_ - Test failures due to floating point differences #81745

PPC64LE - pkg/geo/geomfn - TestSegmentize/GEOMETRYCOLLECTION_ - Test failures due to floating point differences #81745

prashantkhoje commented May 24, 2022 •

edited by cockroach-jira-scripts

Loading

blathers-crl bot commented May 24, 2022

blathers-crl bot commented May 24, 2022

adityamaru commented May 24, 2022

otan commented May 24, 2022

otan commented May 24, 2022

prashantkhoje commented May 25, 2022

otan commented May 25, 2022

prashantkhoje commented May 30, 2022

PPC64LE - pkg/geo/geomfn - TestSegmentize/GEOMETRYCOLLECTION_ - Test failures due to floating point differences #81745

PPC64LE - pkg/geo/geomfn - TestSegmentize/GEOMETRYCOLLECTION_ - Test failures due to floating point differences #81745

Comments

prashantkhoje commented May 24, 2022 • edited by cockroach-jira-scripts Loading

blathers-crl bot commented May 24, 2022

blathers-crl bot commented May 24, 2022

adityamaru commented May 24, 2022

otan commented May 24, 2022

otan commented May 24, 2022

prashantkhoje commented May 25, 2022

otan commented May 25, 2022

prashantkhoje commented May 30, 2022

prashantkhoje commented May 24, 2022 •

edited by cockroach-jira-scripts

Loading