Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: ALTER ROLE ... SET tracing=on; crashes the database #81410

Closed
Xiang-Gu opened this issue May 17, 2022 · 1 comment · Fixed by #81420
Closed

sql: ALTER ROLE ... SET tracing=on; crashes the database #81410

Xiang-Gu opened this issue May 17, 2022 · 1 comment · Fixed by #81420
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-2-temp-unavailability Temp crashes or other availability problems. Can be worked around or resolved by restarting. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented May 17, 2022

Describe the problem

CREATE USER roacher;
ALTER ROLE roacher SET tracing = 'on';

crashes the database with message:

invalid syntax: statement ignored: unexpected error: driver: bad connection
warning: connection lost!
opening new connection: all session settings will be lost
warning: error retrieving the transaction status: dial tcp [::1]:26257: connect: connection refused
warning: connection lost!
opening new connection: all session settings will be lost
warning: error retrieving the database name: dial tcp [::1]:26257: connect: connection refused
root@localhost:26257/? ?>

Jira issue: CRDB-15203

@Xiang-Gu Xiang-Gu added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label May 17, 2022
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 17, 2022
@Xiang-Gu Xiang-Gu added the S-2-temp-unavailability Temp crashes or other availability problems. Can be worked around or resolved by restarting. label May 17, 2022
@rafiss
Copy link
Collaborator

rafiss commented May 17, 2022

I think we probably should disallow setting tracing using ALTER ROLE SET. this variable has special handling, from 61a9676

I noticed that SET LOCAL tracing = 'on; also crashes the database. that might need to be implemented in full.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-2-temp-unavailability Temp crashes or other availability problems. Can be worked around or resolved by restarting. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants